Implement the kernel_generator API using fasta

Implement the kernel_generator API using fasta

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/938d1ba524bc6342faa8747e66222f3972599027

[Siggi Cherem (dart-lang), 2017-05-03 22:02:43]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-05-03 22:03:58]

sigmund@google.com changed reviewers:
+ paulberry@google.com

[Siggi Cherem (dart-lang), 2017-05-03 22:03:58]

note: I moved the old logic with dartk into the perf test to maintain that
benchmark data, but if we want to delete it we can, we just need to update the
benchmark bots.

[Paul Berry, 2017-05-03 22:22:27]

https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/compi...
File pkg/front_end/lib/compiler_options.dart (right):

https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/compi...
pkg/front_end/lib/compiler_options.dart:140: Future<bool>
validateOptions(CompilerOptions options) async {
These checks should be moved into ProcessedOptions.

https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/kerne...
File pkg/front_end/lib/kernel_generator.dart (right):

https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:38: var fs = options.fileSystem;
Don't use options directly here (or elsewhere in this CL).  Instead, wrap it in
ProcessedOptions so that its interpretation is consistent across the front end.

(For instance, this will let us add multi-root support in a future CL by having
ProcessedOptions just wrap the file system with a wrapper that handles
multi-root URIs, and nothing else in the front end will need to be changed)

[Siggi Cherem (dart-lang), 2017-05-03 22:40:14]

https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/kerne...
File pkg/front_end/lib/kernel_generator.dart (right):

https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/kerne...
pkg/front_end/lib/kernel_generator.dart:38: var fs = options.fileSystem;
On 2017/05/03 22:22:26, Paul Berry wrote:
> Don't use options directly here (or elsewhere in this CL).  Instead, wrap it
in
> ProcessedOptions so that its interpretation is consistent across the front
end.
> 
> (For instance, this will let us add multi-root support in a future CL by
having
> ProcessedOptions just wrap the file system with a wrapper that handles
> multi-root URIs, and nothing else in the front end will need to be changed)

good point - if you don't mind, I'd like to do so in a separate change - most of
ProcessedOptions is in terms of APIs that are not yet in use by fasta, so we
need to first migrate fasta to use those APIs before I can stop using it here.

[Paul Berry, 2017-05-04 00:40:52]

On 2017/05/03 22:40:14, Siggi Cherem (dart-lang) wrote:
>
https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/kerne...
> File pkg/front_end/lib/kernel_generator.dart (right):
> 
>
https://codereview.chromium.org/2856223003/diff/20001/pkg/front_end/lib/kerne...
> pkg/front_end/lib/kernel_generator.dart:38: var fs = options.fileSystem;
> On 2017/05/03 22:22:26, Paul Berry wrote:
> > Don't use options directly here (or elsewhere in this CL).  Instead, wrap it
> in
> > ProcessedOptions so that its interpretation is consistent across the front
> end.
> > 
> > (For instance, this will let us add multi-root support in a future CL by
> having
> > ProcessedOptions just wrap the file system with a wrapper that handles
> > multi-root URIs, and nothing else in the front end will need to be changed)
> 
> good point - if you don't mind, I'd like to do so in a separate change - most
of
> ProcessedOptions is in terms of APIs that are not yet in use by fasta, so we
> need to first migrate fasta to use those APIs before I can stop using it here.

Fair enough.  In that case, lgtm.

[Siggi Cherem (dart-lang), 2017-05-04 19:02:10]

Description was changed from

==========
Implement the kernel_generator API using fasta

BUG=
==========

to

==========
Implement the kernel_generator API using fasta

BUG=
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/938d1ba524bc6342faa8747e66222f3972599027
==========

[Siggi Cherem (dart-lang), 2017-05-04 19:02:11]

Committed patchset #1 (id:20001) manually as
938d1ba524bc6342faa8747e66222f3972599027 (presubmit successful).