Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2856163002: [css-grid] Avoid the relayout forced on orthogonal grid items (Closed)
Patch Set: Do no clear overrideContainingBlock Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index 9b70c14246c0977c6e1645927061b89b3aec95f0..9af6417e5c020cef4373baaa5cae8365d91be3ed 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -253,19 +253,8 @@ void LayoutGrid::UpdateBlockLayout(bool relayout_children) {
// we need to clear any override size set previously, so it doesn't
// interfere in current layout execution.
for (auto* child = FirstInFlowChildBox(); child;
- child = child->NextInFlowSiblingBox()) {
+ child = child->NextInFlowSiblingBox())
child->ClearOverrideSize();
- if (!IsOrthogonalChild(*child) ||
- (!SizesLogicalWidthToFitContent(StyleRef().LogicalWidth()) &&
- !StyleRef().LogicalWidth().IsIntrinsicOrAuto()))
- continue;
- // Additionally, we may need to clear containingBlock override sizes and
- // force a layout of the grid items to ensure we get the same result when
- // grid's intrinsic size is computed again in the updateLogicalWidth call
- // bellow.
- child->ClearContainingBlockOverrideSize();
- child->ForceLayout();
- }
UpdateLogicalWidth();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698