Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2856153003: Pass TouchAction bits together with rect in SetTouchEventHandlerRegion (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index be89186618379733becce7107e6ef7f3e41ab966..a7f20bdebdeafac2ff43484764b08c5da4eebd00 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -786,10 +786,15 @@ void ScrollingCoordinator::SetTouchEventTargetRects(
for (const auto& layer_rect : graphics_layer_rects) {
const GraphicsLayer* graphics_layer = layer_rect.key;
- WebVector<WebRect> web_rects(layer_rect.value.size());
- for (size_t i = 0; i < layer_rect.value.size(); ++i)
- web_rects[i] = EnclosingIntRect(layer_rect.value[i]);
- graphics_layer->PlatformLayer()->SetTouchEventHandlerRegion(web_rects);
+ WebVector<WebTouchActionRect> web_touch_action_rect(
wkorman 2017/05/03 20:02:14 I think I prefer WebTouchInfo for the class name,
xidachen 2017/05/04 12:11:21 Done.
+ layer_rect.value.size());
+ for (size_t i = 0; i < layer_rect.value.size(); ++i) {
+ web_touch_action_rect[i].rect = EnclosingIntRect(layer_rect.value[i]);
+ web_touch_action_rect[i].touch_action =
wkorman 2017/05/03 20:02:14 Add TODO(wkorman) here noting that we should route
xidachen 2017/05/04 12:11:21 Done.
+ static_cast<int>(kTouchActionNone);
+ }
+ graphics_layer->PlatformLayer()->SetTouchEventHandlerRegion(
+ web_touch_action_rect);
}
}

Powered by Google App Engine
This is Rietveld 408576698