Pass TouchAction bits together with rect in SetTouchEventHandlerRegion

cc/blink/web_layer_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/blink/web_layer_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 281 matching lines @@
   size_t i = 0;
   for (cc::Region::Iterator region_rects(layer_->non_fast_scrollable_region());
        region_rects.has_rect();
        region_rects.next()) {
     result[i] = region_rects.rect();
     ++i;
   }
   return result;
 }
 
-void WebLayerImpl::SetTouchEventHandlerRegion(const WebVector<WebRect>& rects) {
+void WebLayerImpl::SetTouchEventHandlerRegion(
+    const WebVector<blink::WebTouchActionRect>& touch_action_rect) {

[wkorman, 2017/05/03 20:02:14]

I am hoping that as part of our work we can stop using WebXxx classes, whose
usage in this area is perhaps now legacy from pre-Blink/Chromium-repo-merge, but
am supportive of landing this until we can explore that further.

I think we don't need to use WebVector, WebRect, or WebXxx any more.

[xidachen, 2017/05/04 12:11:21]

I think there is a bit of complexity here, and please correct me if I
misunderstood things:
1). If we use IntRect or gfx::rect in the new class, then we would be doing
things that is very similar to WebRect class, which is:
#if INSIDE_BLINK
  using IntRect
#else
  using gfx::rect
I think that makes things more complicated.

2). If we do use IntRect or gfx::rect, then in here we need to include either
WebKit/Source/platform/ or ui/gfx. At this moment, cc/blink/ is only allowed to
use things under WebKit/Source/public/platform.

To solve this problem systematically, we should investigate this bug:
crbug.com/584551, which is to erase the entire dir of cc/blink/ and that is
basically one class: WebLayer. I am not sure what is the best time for this, now
or after SPv2.

   cc::Region region;
-  for (size_t i = 0; i < rects.size(); ++i)
-    region.Union(rects[i]);
+  for (size_t i = 0; i < touch_action_rect.size(); ++i)
+    region.Union(touch_action_rect[i].rect);
   layer_->SetTouchEventHandlerRegion(region);
 }
 
 WebVector<WebRect> WebLayerImpl::TouchEventHandlerRegion() const {
   size_t num_rects = 0;
   for (cc::Region::Iterator region_rects(layer_->touch_event_handler_region());
        region_rects.has_rect();
        region_rects.next())
     ++num_rects;
 
@@ skipping 166 matching lines @@
 
 void WebLayerImpl::SetHasWillChangeTransformHint(bool has_will_change) {
   layer_->SetHasWillChangeTransformHint(has_will_change);
 }
 
 void WebLayerImpl::ShowScrollbars() {
   layer_->ShowScrollbars();
 }
 
 }  // namespace cc_blink