ios/web/webui/url_data_manager_ios_backend.mm - Issue 2856093004: Generalize content::URLDataSource so that it can be used by the network service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/webui/url_data_manager_ios_backend.mm

Issue 2856093004: Generalize content::URLDataSource so that it can be used by the network service. (Closed)

Patch Set: review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/webui/url_data_manager_ios_backend.mm

diff --git a/ios/web/webui/url_data_manager_ios_backend.mm b/ios/web/webui/url_data_manager_ios_backend.mm

index 23a10945b6268b76c25c2a8cd2a0c086c0da766a..a2b618ba6fe01588a104311ea7196d5420d6aee7 100644

--- a/ios/web/webui/url_data_manager_ios_backend.mm

+++ b/ios/web/webui/url_data_manager_ios_backend.mm

@@ -435,12 +435,11 @@ bool URLDataManagerIOSBackend::StartRequest(const net::URLRequest* request,

if (!source)

return false;

- if (!source->source()->ShouldServiceRequest(request))

+ if (!source->source()->ShouldServiceRequest(request->url()))

return false;

std::string path;

URLToRequestPath(request->url(), &path);

- source->source()->WillServiceRequest(request, &path);

// Save this request so we know where to send the data.

RequestID request_id = next_request_id_++;