Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: chrome/browser/ui/webui/favicon_source.h

Issue 2856093004: Generalize content::URLDataSource so that it can be used by the network service. (Closed)
Patch Set: review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/favicon_source.h
diff --git a/chrome/browser/ui/webui/favicon_source.h b/chrome/browser/ui/webui/favicon_source.h
index 6d253474607ac26d948d9057b7f6ce90def853b3..1f4546c06005d55bafd598bb359ce3f34ace6419 100644
--- a/chrome/browser/ui/webui/favicon_source.h
+++ b/chrome/browser/ui/webui/favicon_source.h
@@ -68,7 +68,9 @@ class FaviconSource : public content::URLDataSource {
std::string GetMimeType(const std::string&) const override;
bool AllowCaching() const override;
bool ShouldReplaceExistingSource() const override;
- bool ShouldServiceRequest(const net::URLRequest* request) const override;
+ bool ShouldServiceRequest(const GURL& url,
+ content::ResourceContext* resource_context,
+ int render_process_id) const override;
protected:
struct IconRequest {

Powered by Google App Engine
This is Rietveld 408576698