Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8627)

Unified Diff: chrome/browser/ui/webui/favicon_source.cc

Issue 2856093004: Generalize content::URLDataSource so that it can be used by the network service. (Closed)
Patch Set: review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/favicon_source.cc
diff --git a/chrome/browser/ui/webui/favicon_source.cc b/chrome/browser/ui/webui/favicon_source.cc
index fca040d2370a60ea08cf6587f1f834b86eb0ac20..f9e9b84455290fab17e2d081aedf7b8d36137ae4 100644
--- a/chrome/browser/ui/webui/favicon_source.cc
+++ b/chrome/browser/ui/webui/favicon_source.cc
@@ -142,10 +142,16 @@ bool FaviconSource::ShouldReplaceExistingSource() const {
return false;
}
-bool FaviconSource::ShouldServiceRequest(const net::URLRequest* request) const {
- if (request->url().SchemeIs(chrome::kChromeSearchScheme))
- return InstantIOContext::ShouldServiceRequest(request);
- return URLDataSource::ShouldServiceRequest(request);
+bool FaviconSource::ShouldServiceRequest(
+ const GURL& url,
+ content::ResourceContext* resource_context,
+ int render_process_id) const {
+ if (url.SchemeIs(chrome::kChromeSearchScheme)) {
+ return InstantIOContext::ShouldServiceRequest(url, resource_context,
+ render_process_id);
+ }
+ return URLDataSource::ShouldServiceRequest(url, resource_context,
+ render_process_id);
}
bool FaviconSource::HandleMissingResource(const IconRequest& request) {

Powered by Google App Engine
This is Rietveld 408576698