chrome/browser/ui/webui/fallback_icon_source.h - Issue 2856093004: Generalize content::URLDataSource so that it can be used by the network service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/fallback_icon_source.h

Issue 2856093004: Generalize content::URLDataSource so that it can be used by the network service. (Closed)

Patch Set: review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/fallback_icon_source.h

diff --git a/chrome/browser/ui/webui/fallback_icon_source.h b/chrome/browser/ui/webui/fallback_icon_source.h

index 381521bec8ceedab7a3d22c1c8737a21a2d56b9e..5526f77a0c50fd89332812f6f992df975aae3187 100644

--- a/chrome/browser/ui/webui/fallback_icon_source.h

+++ b/chrome/browser/ui/webui/fallback_icon_source.h

@@ -68,7 +68,9 @@ class FallbackIconSource : public content::URLDataSource {

std::string GetMimeType(const std::string&) const override;

bool AllowCaching() const override;

bool ShouldReplaceExistingSource() const override;

- bool ShouldServiceRequest(const net::URLRequest* request) const override;

+ bool ShouldServiceRequest(const GURL& url,

+ content::ResourceContext* resource_context,

+ int render_process_id) const override;

private:

void SendFallbackIconHelper(