Update TextSelection for non-user initiated events

content/browser/renderer_host/text_input_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/text_input_manager.h"
 
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/common/view_messages.h"
 #include "ui/gfx/geometry/rect.h"
@@ skipping 218 matching lines @@
   composition_range_info_map_[view].range.set_start(range.start());
   composition_range_info_map_[view].range.set_end(range.end());
 
   for (auto& observer : observer_list_)
     observer.OnImeCompositionRangeChanged(this, view);
 }
 
 void TextInputManager::SelectionChanged(RenderWidgetHostViewBase* view,
                                         const base::string16& text,
                                         size_t offset,
-                                        const gfx::Range& range) {
+                                        const gfx::Range& range,
+                                        bool user_initiated) {
   DCHECK(IsRegistered(view));
-  text_selection_map_[view].SetSelection(text, offset, range);
+  text_selection_map_[view].SetSelection(text, offset, range, user_initiated);
   for (auto& observer : observer_list_)
     observer.OnTextSelectionChanged(this, view);
 }
 
 void TextInputManager::Register(RenderWidgetHostViewBase* view) {
   DCHECK(!IsRegistered(view));
 
   text_input_state_map_[view] = TextInputState();
   selection_region_map_[view] = SelectionRegion();
   composition_range_info_map_[view] = CompositionRangeInfo();
@@ skipping 54 matching lines @@
     const SelectionRegion& other) = default;
 
 TextInputManager::CompositionRangeInfo::CompositionRangeInfo() {}
 
 TextInputManager::CompositionRangeInfo::CompositionRangeInfo(
     const CompositionRangeInfo& other) = default;
 
 TextInputManager::CompositionRangeInfo::~CompositionRangeInfo() {}
 
 TextInputManager::TextSelection::TextSelection()
     : offset_(0), range_(gfx::Range::InvalidRange()) {}

[EhsanK, 2017/05/04 00:16:31]

(nit) Initialize |user_initiated| (to false?).

[nasko, 2017/05/04 16:10:24]

With C++11, we can now initialize it in the header file too.

[Peter Varga, 2017/05/04 16:33:45]

ok, I will check this.

 
 TextInputManager::TextSelection::TextSelection(const TextSelection& other) =
     default;
 
 TextInputManager::TextSelection::~TextSelection() {}
 
 void TextInputManager::TextSelection::SetSelection(const base::string16& text,
                                                    size_t offset,
-                                                   const gfx::Range& range) {
+                                                   const gfx::Range& range,
+                                                   bool user_initiated) {
   text_ = text;
   range_.set_start(range.start());
   range_.set_end(range.end());
   offset_ = offset;
+  user_initiated_ = user_initiated;
 
   // Update the selected text.
   selected_text_.clear();
   if (!text.empty() && !range.is_empty()) {
     size_t pos = range.GetMin() - offset;
     size_t n = range.length();
     if (pos + n > text.length()) {
       LOG(WARNING)
           << "The text cannot fully cover range (selection's end point "
              "exceeds text length).";
     }
 
     if (pos >= text.length()) {
       LOG(WARNING) << "The text cannot cover range (selection range's starting "
                       "point exceeds text length).";
     } else {
       selected_text_.append(text.substr(pos, n));
     }
   }
 }
 
 }  // namespace content