Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2856093003: Update TextSelection for non-user initiated events (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_base.h" 5 #include "content/browser/renderer_host/render_widget_host_view_base.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "content/browser/accessibility/browser_accessibility_manager.h" 9 #include "content/browser/accessibility/browser_accessibility_manager.h"
10 #include "content/browser/gpu/gpu_data_manager_impl.h" 10 #include "content/browser/gpu/gpu_data_manager_impl.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 NOTREACHED() << "Selection bounds should be routed through the compositor."; 112 NOTREACHED() << "Selection bounds should be routed through the compositor.";
113 #endif 113 #endif
114 } 114 }
115 115
116 float RenderWidgetHostViewBase::GetBottomControlsHeight() const { 116 float RenderWidgetHostViewBase::GetBottomControlsHeight() const {
117 return 0.f; 117 return 0.f;
118 } 118 }
119 119
120 void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text, 120 void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text,
121 size_t offset, 121 size_t offset,
122 const gfx::Range& range) { 122 const gfx::Range& range,
123 bool user_initiated) {
123 if (GetTextInputManager()) 124 if (GetTextInputManager())
124 GetTextInputManager()->SelectionChanged(this, text, offset, range); 125 GetTextInputManager()->SelectionChanged(this, text, offset, range,
EhsanK 2017/05/04 00:16:31 (nit) brackets given that the statement is longer
126 user_initiated);
125 } 127 }
126 128
127 gfx::Size RenderWidgetHostViewBase::GetRequestedRendererSize() const { 129 gfx::Size RenderWidgetHostViewBase::GetRequestedRendererSize() const {
128 return GetViewBounds().size(); 130 return GetViewBounds().size();
129 } 131 }
130 132
131 ui::TextInputClient* RenderWidgetHostViewBase::GetTextInputClient() { 133 ui::TextInputClient* RenderWidgetHostViewBase::GetTextInputClient() {
132 NOTREACHED(); 134 NOTREACHED();
133 return NULL; 135 return NULL;
134 } 136 }
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 501
500 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const { 502 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const {
501 return false; 503 return false;
502 } 504 }
503 505
504 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const { 506 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const {
505 return cc::SurfaceId(); 507 return cc::SurfaceId();
506 } 508 }
507 509
508 } // namespace content 510 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698