Fix some problems with TaskManagerBrowserTest.PopulateWebCacheFields:

Fix some problems with TaskManagerBrowserTest.PopulateWebCacheFields:

- wait for an actual update to occur; otherwise we're not testing the real thing
- change DCHECKs to EXPECT_EQs; that's what we should use in tests

This change should also fix the crashiness of this test.

TEST=browser_tests
BUG=42301
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55449

[Jay Civelli, 2010-08-05 22:05:47]

http://codereview.chromium.org/2856091/diff/1/5
File chrome/browser/task_manager_resource_providers.cc (left):

http://codereview.chromium.org/2856091/diff/1/5#oldcode64
chrome/browser/task_manager_resource_providers.cc:64: stats_.images.size = 0;
Why aren't we initializing these anymore?

[Paweł Hajdan Jr., 2010-08-05 22:16:03]

http://codereview.chromium.org/2856091/diff/1/5
File chrome/browser/task_manager_resource_providers.cc (left):

http://codereview.chromium.org/2856091/diff/1/5#oldcode64
chrome/browser/task_manager_resource_providers.cc:64: stats_.images.size = 0;
On 2010/08/05 22:05:47, Jay Civelli wrote:
> Why aren't we initializing these anymore?

We won't use them until they are initialized by real data from WebKit, so this
initialization is not needed now.

[Jay Civelli, 2010-08-06 00:17:26]

I see. (But if that code was to be erroneously changed in the future
we might be using uninitialized data.)

LGTM

On Thu, Aug 5, 2010 at 3:16 PM,  <phajdan.jr@chromium.org> wrote:
>
> http://codereview.chromium.org/2856091/diff/1/5
> File chrome/browser/task_manager_resource_providers.cc (left):
>
> http://codereview.chromium.org/2856091/diff/1/5#oldcode64
> chrome/browser/task_manager_resource_providers.cc:64: stats_.images.size
> = 0;
> On 2010/08/05 22:05:47, Jay Civelli wrote:
>>
>> Why aren't we initializing these anymore?
>
> We won't use them until they are initialized by real data from WebKit,
> so this initialization is not needed now.
>
> http://codereview.chromium.org/2856091/show
>

[jamesr, 2010-08-06 18:29:40]

http://codereview.chromium.org/2856091/diff/1/4
File chrome/browser/task_manager_browsertest.cc (right):

http://codereview.chromium.org/2856091/diff/1/4#newcode258
chrome/browser/task_manager_browsertest.cc:258: // This way at least one of them
must have occurred after adding the tab.
Are you sure you'll always get 2?

http://codereview.chromium.org/2856091/diff/1/5
File chrome/browser/task_manager_resource_providers.cc (left):

http://codereview.chromium.org/2856091/diff/1/5#oldcode64
chrome/browser/task_manager_resource_providers.cc:64: stats_.images.size = 0;
On 2010/08/05 22:16:03, Paweł Hajdan Jr. wrote:
> On 2010/08/05 22:05:47, Jay Civelli wrote:
> > Why aren't we initializing these anymore?
> 
> We won't use them until they are initialized by real data from WebKit, so this
> initialization is not needed now.

Feels dangerous to leave members uninitialized, even if we don't intend to query
them.

[jamesr, 2010-08-06 18:54:53]

LGTM