components/sync_preferences/pref_service_syncable_factory.cc - Issue 2856083002: Pref service: support for incognito prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_preferences/pref_service_syncable_factory.cc

Issue 2856083002: Pref service: support for incognito prefs (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_preferences/pref_service_syncable_factory.cc

diff --git a/components/sync_preferences/pref_service_syncable_factory.cc b/components/sync_preferences/pref_service_syncable_factory.cc

index 66d98feebfd88b66680246a91be4484f974c62f9..198fb35ea2543fde70c7224f15ff4106cfae5335 100644

--- a/components/sync_preferences/pref_service_syncable_factory.cc

+++ b/components/sync_preferences/pref_service_syncable_factory.cc

@@ -97,6 +97,7 @@ std::unique_ptr<PrefServiceSyncable> PrefServiceSyncableFactory::CreateSyncable(

auto recommended = CreateRegisteredPrefStore(

registry.get(), recommended_prefs_, PrefValueStore::RECOMMENDED_STORE);

+ // TODO(sammc): Register Mojo user pref store once implemented.

std::unique_ptr<PrefServiceSyncable> pref_service(new PrefServiceSyncable(

pref_notifier,

new PrefValueStore(managed.get(), supervised.get(), extension.get(),