Pref service: support for incognito prefs

components/prefs/pref_value_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PREFS_PREF_VALUE_STORE_H_
 #define COMPONENTS_PREFS_PREF_VALUE_STORE_H_
 
 #include <map>
 #include <string>
 #include <type_traits>
@@ skipping 20 matching lines @@
  public:
   typedef base::Callback<void(const std::string&)> PrefChangedCallback;
 
   // PrefStores must be listed here in order from highest to lowest priority.
   //   MANAGED contains all managed preference values that are provided by
   //      mandatory policies (e.g. Windows Group Policy or cloud policy).
   //   SUPERVISED_USER contains preferences that are valid for supervised users.
   //   EXTENSION contains preference values set by extensions.
   //   COMMAND_LINE contains preference values set by command-line switches.
   //   USER contains all user-set preference values.
+  //   INCOGNITO_STORE contains preferences that were written while in incognito

[Sam McNally, 2017/05/10 01:22:16]

Isn't that USER_STORE when running in incognito? INCOGNITO_STORE in this
position would refer to the USER_STORE of the base profile.

+  //      mode.
   //   RECOMMENDED contains all preferences that are provided by recommended
   //      policies.
   //   DEFAULT contains all application default preference values.
   enum PrefStoreType {
     // INVALID_STORE is not associated with an actual PrefStore but used as
     // an invalid marker, e.g. as a return value.
     INVALID_STORE = -1,
     MANAGED_STORE = 0,
     SUPERVISED_USER_STORE,
     EXTENSION_STORE,
     COMMAND_LINE_STORE,
     USER_STORE,
+    INCOGNITO_STORE,
     RECOMMENDED_STORE,
     DEFAULT_STORE,
     PREF_STORE_TYPE_MAX = DEFAULT_STORE
   };
 
   // In decreasing order of precedence:
   //   |managed_prefs| contains all preferences from mandatory policies.
   //   |supervised_user_prefs| contains all preferences from supervised user
   //        settings, i.e. settings configured for a supervised user by their
   //        custodian.
@@ skipping 201 matching lines @@
 struct hash<PrefValueStore::PrefStoreType> {
   size_t operator()(PrefValueStore::PrefStoreType type) const {
     return std::hash<
         std::underlying_type<PrefValueStore::PrefStoreType>::type>()(type);
   }
 };
 
 }  // namespace std
 
 #endif  // COMPONENTS_PREFS_PREF_VALUE_STORE_H_