Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc

Issue 2856053004: [Refactor] Use ScopedTestPublicSessionLoginState in code (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/page_capture/page_capture_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc b/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
index 081648ce87f3a9bb2009d4be63562c16b81ed793..49499a86d1bfbe1d97f11b0ebc8d66bdb2ce6af2 100644
--- a/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
+++ b/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
@@ -10,6 +10,7 @@
#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chromeos/login/login_state.h"
+#include "chromeos/login/scoped_test_public_session_login_state.h"
#include "extensions/common/extension.h"
#include "extensions/common/manifest.h"
#include "extensions/common/manifest_constants.h"
@@ -85,12 +86,8 @@ TEST(PermissionsUpdaterDelegateChromeOSTest, NoFilteringOutsidePublicSession) {
TEST(PermissionsUpdaterDelegateChromeOSTest,
FilterNonWhitelistedInsidePublicSession) {
+ chromeos::ScopedTestPublicSessionLoginState login_state;
PermissionsUpdaterDelegateChromeOS delegate;
- // Set Public Session state.
- chromeos::LoginState::Initialize();
- chromeos::LoginState::Get()->SetLoggedInState(
- chromeos::LoginState::LOGGED_IN_ACTIVE,
- chromeos::LoginState::LOGGED_IN_USER_PUBLIC_ACCOUNT);
// Whitelisted extension, nothing gets filtered.
auto extension = CreateExtension(kWhitelistedId);
@@ -104,9 +101,6 @@ TEST(PermissionsUpdaterDelegateChromeOSTest,
granted_permissions = CreatePermissions();
delegate.InitializePermissions(extension.get(), &granted_permissions);
EXPECT_EQ(*CreatePermissions(false), *granted_permissions);
-
- // Reset state at the end of test.
- chromeos::LoginState::Shutdown();
}
} // namespace extensions
« no previous file with comments | « no previous file | chrome/browser/extensions/api/page_capture/page_capture_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698