Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Side by Side Diff: components/offline_pages/core/offline_page_model_impl.h

Issue 2856053003: [Offline pages] Fix order of error checking so URL mismatch would not override other error codes (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/offline_pages/core/offline_page_model_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_IMPL_H_ 5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_IMPL_H_
6 #define COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_IMPL_H_ 6 #define COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 const std::vector<OfflinePageItem>& offline_pages); 156 const std::vector<OfflinePageItem>& offline_pages);
157 void FinalizeModelLoad(); 157 void FinalizeModelLoad();
158 158
159 // Steps for saving a page offline. 159 // Steps for saving a page offline.
160 void OnCreateArchiveDone(const SavePageParams& save_page_params, 160 void OnCreateArchiveDone(const SavePageParams& save_page_params,
161 int64_t offline_id, 161 int64_t offline_id,
162 const base::Time& start_time, 162 const base::Time& start_time,
163 const SavePageCallback& callback, 163 const SavePageCallback& callback,
164 OfflinePageArchiver* archiver, 164 OfflinePageArchiver* archiver,
165 OfflinePageArchiver::ArchiverResult result, 165 OfflinePageArchiver::ArchiverResult result,
166 const GURL& url, 166 const GURL& saved_url,
167 const base::FilePath& file_path, 167 const base::FilePath& file_path,
168 const base::string16& title, 168 const base::string16& title,
169 int64_t file_size); 169 int64_t file_size);
170 void OnAddOfflinePageDone(OfflinePageArchiver* archiver, 170 void OnAddOfflinePageDone(OfflinePageArchiver* archiver,
171 const base::FilePath& file_path, 171 const base::FilePath& file_path,
172 const SavePageCallback& callback, 172 const SavePageCallback& callback,
173 const OfflinePageItem& offline_page, 173 const OfflinePageItem& offline_page,
174 ItemActionStatus status); 174 ItemActionStatus status);
175 void InformSavePageDone(const SavePageCallback& callback, 175 void InformSavePageDone(const SavePageCallback& callback,
176 SavePageResult result, 176 SavePageResult result,
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 base::Clock* testing_clock_; 287 base::Clock* testing_clock_;
288 288
289 base::WeakPtrFactory<OfflinePageModelImpl> weak_ptr_factory_; 289 base::WeakPtrFactory<OfflinePageModelImpl> weak_ptr_factory_;
290 290
291 DISALLOW_COPY_AND_ASSIGN(OfflinePageModelImpl); 291 DISALLOW_COPY_AND_ASSIGN(OfflinePageModelImpl);
292 }; 292 };
293 293
294 } // namespace offline_pages 294 } // namespace offline_pages
295 295
296 #endif // COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_IMPL_H_ 296 #endif // COMPONENTS_OFFLINE_PAGES_CORE_OFFLINE_PAGE_MODEL_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | components/offline_pages/core/offline_page_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698