components/safe_browsing/password_protection/password_protection_request.h - Issue 2856033002: Add finch control of user population in low reputation requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing/password_protection/password_protection_request.h

Issue 2856033002: Add finch control of user population in low reputation requests (Closed)

Patch Set: replace PasswordReuse with ProtectedPasswordEntry Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing/csd.proto ('K') | « components/safe_browsing/csd.proto ('k') | components/safe_browsing/password_protection/password_protection_request.cc » ('j') | components/safe_browsing/password_protection/password_protection_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing/password_protection/password_protection_request.h

diff --git a/components/safe_browsing/password_protection/password_protection_request.h b/components/safe_browsing/password_protection/password_protection_request.h

index 7eec452eca1aaf4ceca466eadeb25661616fc3c7..e456416a4cec13b05e26e6b40166a474a1f36364 100644

--- a/components/safe_browsing/password_protection/password_protection_request.h

+++ b/components/safe_browsing/password_protection/password_protection_request.h

@@ -49,8 +49,8 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<

TIMEDOUT = 3,

MATCHED_WHITELIST = 4,

RESPONSE_ALREADY_CACHED = 5,

- NO_EXTENDED_REPORTING = 6,

- INCOGNITO = 7,

+ NO_EXTENDED_REPORTING = 6, // Deprecated.

Nathan Parker 2017/05/05 20:58:22 You could comment these out, or rename them _DEPRE

Jialiu Lin 2017/05/05 22:19:32 Done.

+ INCOGNITO = 7, // Deprecated.

REQUEST_MALFORMED = 8,

FETCH_FAILED = 9,

RESPONSE_MALFORMED = 10,