chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 2856033002: Add finch control of user population in low reputation requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 2856033002: Add finch control of user population in low reputation requests (Closed)

Patch Set: address comments from nparker@ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/safe_browsing/chrome_password_protection_service.h » ('j') | chrome/browser/safe_browsing/chrome_password_protection_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index b308749f850ea39ed50343668029e370a19e9034..d3a8f26c8513f259146f59665be4f9a787f824fd 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -83,7 +83,8 @@ class MockPasswordProtectionService

safe_browsing::LoginReputationClientRequest::Frame*));

MOCK_METHOD0(IsExtendedReporting, bool());

MOCK_METHOD0(IsIncognito, bool());

- MOCK_METHOD0(IsPingingEnabled, bool());

+ MOCK_METHOD1(IsPingingEnabled, bool(const base::Feature&));

+ MOCK_METHOD0(IsHistorySyncEnabled, bool());

MOCK_METHOD3(MaybeStartLowReputationRequest,

void(const GURL&, const GURL&, const GURL&));