Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: DEPS

Issue 2855973006: Revert "[infra] Roll clang to match the version used by Flutter" (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/android/config.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DEPS
diff --git a/DEPS b/DEPS
index 578d9833e9bfc5991d9a686d605143b158a8ebb0..2ebbfbb795cf6dfa1149bd8ce724e4d35d10ef95 100644
--- a/DEPS
+++ b/DEPS
@@ -23,7 +23,6 @@ vars = {
# Chromium git
"chromium_git": "https://chromium.googlesource.com",
- "fuchsia_git": "https://fuchsia.googlesource.com",
# Only use this temporarily while waiting for a mirror for a new package.
"github_dartlang": "https://github.com/dart-lang/%s.git",
@@ -31,12 +30,9 @@ vars = {
"gyp_rev": "@6ee91ad8659871916f9aa840d42e1513befdf638",
"co19_rev": "@4af9ef149be554216c5bb16cbac8e50d4c28cdf1",
- # Revisions of GN related dependencies. This should match the revision
- # pulled by Flutter.
- "buildtools_revision": "@c8db819853bcf8ce1635a8b7a395820f39b5a9fc",
-
- # Scripts that make 'git cl format' work.
- "clang_format_scripts_rev": "@c09c8deeac31f05bd801995c475e7c8070f9ecda",
+ # Revisions of GN related dependencies.
+ "buildtools_revision": "@39b1db2ab4aa4b2ccaa263c29bdf63e7c1ee28aa",
+ "clang_format_rev": "@0ed791d1387a3c9146ea6c453c646f3c0fc97784",
"gperftools_revision": "@02eeed29df112728564a5dde6417fa4622b57a06",
@@ -136,10 +132,11 @@ deps = {
# Stuff needed for GN build.
Var("dart_root") + "/buildtools":
- Var("fuchsia_git") + "/buildtools" + Var("buildtools_revision"),
+ Var('chromium_git') + '/chromium/buildtools.git' +
+ Var('buildtools_revision'),
Var("dart_root") + "/buildtools/clang_format/script":
Var("chromium_git") + "/chromium/llvm-project/cfe/tools/clang-format.git" +
- Var("clang_format_scripts_rev"),
+ Var("clang_format_rev"),
Var("dart_root") + "/tests/co19/src":
(Var("github_mirror") % "co19") + Var("co19_rev"),
@@ -349,6 +346,11 @@ deps = {
}
deps_os = {
+ "android": {
+ Var("dart_root") + "/third_party/android_tools":
+ Var("chromium_git") + "/android_tools.git" +
+ "@aaeda3d69df4b4352e3cac7c16bea7f16bd1ec12",
+ },
"win": {
Var("dart_root") + "/third_party/cygwin":
Var("chromium_git") + "/chromium/deps/cygwin.git" +
@@ -359,6 +361,98 @@ deps_os = {
# TODO(iposva): Move the necessary tools so that hooks can be run
# without the runtime being available.
hooks = [
+ # Pull GN binaries. This needs to be before running GYP below.
+ {
+ 'name': 'gn_linux64',
+ 'pattern': '.',
+ 'action': [
+ 'download_from_google_storage',
+ '--no_auth',
+ '--no_resume',
+ '--quiet',
+ '--platform=linux*',
+ '--bucket',
+ 'chromium-gn',
+ '-s',
+ Var('dart_root') + '/buildtools/linux64/gn.sha1',
+ ],
+ },
+ {
+ 'name': 'gn_mac',
+ 'pattern': '.',
+ 'action': [
+ 'download_from_google_storage',
+ '--no_auth',
+ '--no_resume',
+ '--quiet',
+ '--platform=darwin',
+ '--bucket',
+ 'chromium-gn',
+ '-s',
+ Var('dart_root') + '/buildtools/mac/gn.sha1',
+ ],
+ },
+ {
+ 'name': 'gn_win',
+ 'pattern': '.',
+ 'action': [
+ 'download_from_google_storage',
+ '--no_auth',
+ '--no_resume',
+ '--quiet',
+ '--platform=win*',
+ '--bucket',
+ 'chromium-gn',
+ '-s',
+ Var('dart_root') + '/buildtools/win/gn.exe.sha1',
+ ],
+ },
+ # Pull clang-format binaries using checked-in hashes.
+ {
+ 'name': 'clang_format_win',
+ 'pattern': '.',
+ 'action': [
+ 'download_from_google_storage',
+ '--no_auth',
+ '--no_resume',
+ '--quiet',
+ '--platform=win32',
+ '--bucket',
+ 'chromium-clang-format',
+ '-s',
+ Var('dart_root') + '/buildtools/win/clang-format.exe.sha1',
+ ],
+ },
+ {
+ 'name': 'clang_format_linux',
+ 'pattern': '.',
+ 'action': [
+ 'download_from_google_storage',
+ '--no_auth',
+ '--no_resume',
+ '--quiet',
+ '--platform=linux*',
+ '--bucket',
+ 'chromium-clang-format',
+ '-s',
+ Var('dart_root') + '/buildtools/linux64/clang-format.sha1',
+ ],
+ },
+ {
+ 'name': 'clang_format_mac',
+ 'pattern': '.',
+ 'action': [
+ 'download_from_google_storage',
+ '--no_auth',
+ '--no_resume',
+ '--quiet',
+ '--platform=darwin',
+ '--bucket',
+ 'chromium-clang-format',
+ '-s',
+ Var('dart_root') + '/buildtools/mac/clang-format.sha1',
+ ],
+ },
{
'name': 'd8_testing_binaries',
'pattern': '.',
@@ -465,6 +559,21 @@ hooks = [
],
},
{
+ "name": "clang",
+ "pattern": ".",
+ "action": [
+ "download_from_google_storage",
+ "--no_auth",
+ "--no_resume",
+ "--bucket",
+ "dart-dependencies",
+ "--platform=linux*",
+ "--extract",
+ "-s",
+ Var('dart_root') + "/third_party/clang.tar.gz.sha1",
+ ],
+ },
+ {
# Pull Debian wheezy sysroot for i386 Linux
'name': 'sysroot_i386',
'pattern': '.',
@@ -479,14 +588,10 @@ hooks = [
'--running-as-hook', '--arch', 'amd64'],
},
{
- 'name': 'download_android_tools',
- 'pattern': '.',
- 'action': ['python', 'sdk/tools/android/download_android_tools.py'],
- },
- {
- 'name': 'buildtools',
+ # Pull clang if needed or requested via GYP_DEFINES.
+ 'name': 'gn_clang',
'pattern': '.',
- 'action': ['python', 'sdk/tools/buildtools/update.py'],
+ 'action': ['python', 'sdk/tools/clang/scripts/update.py', '--if-needed'],
},
{
# Update the Windows toolchain if necessary.
« no previous file with comments | « no previous file | build/config/android/config.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698