Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2855973006: Revert "[infra] Roll clang to match the version used by Flutter" (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "[infra] Roll clang to match the version used by Flutter" This reverts commit cc968ca45b8b1dbbccaf630ef5d903f7925d6d41. This CL will have to be relanded in two pieces so that the update to tools/gn.py lands before the unmodified version can invoke the updated GN binary. Committed: https://github.com/dart-lang/sdk/commit/958c25c1dbfca75ea26b0e3c3dcf403794df2a95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1802 lines, -302 lines) Patch
M DEPS View 7 chunks +121 lines, -16 lines 0 comments Download
M build/config/android/config.gni View 2 chunks +2 lines, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 5 chunks +34 lines, -22 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +1 line, -10 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/android/VERSION_LINUX_NDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/VERSION_LINUX_SDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/VERSION_MACOSX_NDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/VERSION_MACOSX_SDK View 1 chunk +0 lines, -1 line 0 comments Download
D tools/android/download_android_tools.py View 1 chunk +0 lines, -104 lines 0 comments Download
M tools/build.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/buildtools/linux64/clang-format View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/buildtools/mac/clang-format View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/buildtools/update.py View 1 chunk +0 lines, -88 lines 0 comments Download
D tools/buildtools/win/clang-format.exe.sha1 View 1 chunk +0 lines, -2 lines 0 comments Download
A tools/clang/scripts/update.py View 1 chunk +909 lines, -0 lines 0 comments Download
A tools/clang/scripts/update.sh View 1 chunk +724 lines, -0 lines 0 comments Download
M tools/gn.py View 3 chunks +5 lines, -4 lines 0 comments Download
M tools/ninja.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 7 months ago (2017-05-03 22:16:08 UTC) #2
zra
TBR
3 years, 7 months ago (2017-05-03 22:16:13 UTC) #3
zra
3 years, 7 months ago (2017-05-03 22:16:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
958c25c1dbfca75ea26b0e3c3dcf403794df2a95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698