Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6332)

Unified Diff: chrome/test/data/pdf/gesture_detector_test.js

Issue 2855953003: Handle long press in PDF documents. (Closed)
Patch Set: Review feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/pdf/gesture_detector_test.js
diff --git a/chrome/test/data/pdf/gesture_detector_test.js b/chrome/test/data/pdf/gesture_detector_test.js
index c038e28f09fab2afe977a4995df1c1a213028554..3131488b343db76d019c70bf6048e8cce5152328 100644
--- a/chrome/test/data/pdf/gesture_detector_test.js
+++ b/chrome/test/data/pdf/gesture_detector_test.js
@@ -212,6 +212,43 @@ chrome.test.runTests(function() {
chrome.test.assertTrue(pinchUpdateEvent.defaultPrevented);
chrome.test.succeed();
+ },
+
+ function testWasTwoFingerTouch() {
+ let stubElement = new StubElement();
+ let gestureDetector = new GestureDetector(stubElement);
+
+
+ chrome.test.assertFalse(gestureDetector.wasTwoFingerTouch(),
+ "Should not have two finger touch before first touch event.");
+
+ stubElement.sendEvent(new MockTouchEvent('touchstart', [
+ {clientX: 0, clientY: 0}
+ ]));
+ chrome.test.assertFalse(gestureDetector.wasTwoFingerTouch(),
+ "Should not have a two finger touch with no touches.");
Kevin McNee 2017/05/04 18:29:34 nit: update reason as well
dsinclair 2017/05/04 20:26:17 Done.
+
+ stubElement.sendEvent(new MockTouchEvent('touchstart', [
+ {clientX: 0, clientY: 0},
+ {clientX: 2, clientY: 2}
+ ]));
+ chrome.test.assertTrue(gestureDetector.wasTwoFingerTouch(),
+ "Should have a two finger touch.");
+
+ // Make sure we keep |wasTwoFingerTouch| true after the end event.
+ stubElement.sendEvent(new MockTouchEvent('touchend', []));
+ chrome.test.assertTrue(gestureDetector.wasTwoFingerTouch(),
+ "Should maintain two finger touch after touchend.");
+
+ stubElement.sendEvent(new MockTouchEvent('touchstart', [
+ {clientX: 0, clientY: 0},
+ {clientX: 2, clientY: 2},
+ {clientX: 4, clientY: 4}
+ ]));
+ chrome.test.assertFalse(gestureDetector.wasTwoFingerTouch(),
+ "Should not have two finger touch with 3 touches.");
+
+ chrome.test.succeed();
}
];
}());

Powered by Google App Engine
This is Rietveld 408576698