Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2855883008: Make test.dart strong mode clean! (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 1629167fd62aafcaad43b0750a989b5e6c72d500..b63159d7096dc1bb7ae583b7bf86e153662b6eee 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -161,7 +161,7 @@ abstract class CompilerConfiguration {
String buildDir,
String tempDir,
CommandBuilder commandBuilder,
- List arguments,
+ List<String> arguments,
Map<String, String> environmentOverrides) {
return new CommandArtifact([], null, null);
}
@@ -256,7 +256,7 @@ class DartKCompilerConfiguration extends CompilerConfiguration {
String outputFileName,
String buildDir,
CommandBuilder commandBuilder,
- List arguments,
+ List<String> arguments,
Map<String, String> environmentOverrides) {
Iterable<String> extraArguments = [
'--sdk',
@@ -275,7 +275,7 @@ class DartKCompilerConfiguration extends CompilerConfiguration {
true,
bootstrapDependencies(buildDir),
computeCompilerPath(buildDir),
- []..addAll(arguments)..addAll(extraArguments),
+ <String>[]..addAll(arguments)..addAll(extraArguments),
environmentOverrides);
}
@@ -283,7 +283,7 @@ class DartKCompilerConfiguration extends CompilerConfiguration {
String buildDir,
String tempDir,
CommandBuilder commandBuilder,
- List arguments,
+ List<String> arguments,
Map<String, String> environmentOverrides) {
return new CommandArtifact(<Command>[
this.computeCompilationCommand('$tempDir/out.dill', buildDir,

Powered by Google App Engine
This is Rietveld 408576698