Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2855883008: Make test.dart strong mode clean! (Closed)

Created:
3 years, 7 months ago by Bob Nystrom
Modified:
3 years, 5 months ago
Reviewers:
Bill Hesse, kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -56 lines) Patch
A tools/testing/dart/.analysis_options View 1 chunk +2 lines, -0 lines 1 comment Download
M tools/testing/dart/compiler_configuration.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 17 chunks +32 lines, -31 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 9 chunks +17 lines, -19 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Bob Nystrom
3 years, 7 months ago (2017-05-04 00:05:59 UTC) #2
kevmoo
DBC https://codereview.chromium.org/2855883008/diff/1/tools/testing/dart/.analysis_options File tools/testing/dart/.analysis_options (right): https://codereview.chromium.org/2855883008/diff/1/tools/testing/dart/.analysis_options#newcode1 tools/testing/dart/.analysis_options:1: analyzer: please use `analysis_options.yaml`
3 years, 7 months ago (2017-05-04 04:22:53 UTC) #4
Bill Hesse
lgtm https://codereview.chromium.org/2855883008/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/2855883008/diff/1/tools/testing/dart/test_suite.dart#newcode430 tools/testing/dart/test_suite.dart:430: var directory = entity as Directory; I'm pretty ...
3 years, 7 months ago (2017-05-04 15:49:38 UTC) #5
Bob Nystrom
Committed patchset #1 (id:1) manually as f5471fb948525aad2d67b392e2da566c2641d4bd (presubmit successful).
3 years, 7 months ago (2017-05-04 17:48:44 UTC) #7
Bob Nystrom
3 years, 5 months ago (2017-07-18 18:06:17 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2855883008/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2855883008/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:430: var directory = entity as Directory;
On 2017/05/04 15:49:38, Bill Hesse wrote:
> I'm pretty annoyed that this is needed.  Oh well.

Yes. The long term fix is to add a method to Iterable, like of<T> that is
explicitly a .where() that filters on type and produces a result sequence of the
correct type. This is what .NET does.

We just don't have that yet (since it's a breaking change to add a method to
Iterable). Hence the annoying workaround.

Powered by Google App Engine
This is Rietveld 408576698