Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2855883003: Widget details for Flutter `children:` param completions. (Closed)

Created:
3 years, 7 months ago by pquitslund
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -87 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 4 chunks +15 lines, -30 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 10 chunks +29 lines, -57 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
3 years, 7 months ago (2017-05-02 19:33:55 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2855883003/diff/1/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart File pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart (right): https://codereview.chromium.org/2855883003/diff/1/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart#newcode907 pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart:907: defaultArgListString: null, Should we remove these fields from ...
3 years, 7 months ago (2017-05-02 20:25:29 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/2855883003/diff/1/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart File pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart (right): https://codereview.chromium.org/2855883003/diff/1/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart#newcode907 pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart:907: defaultArgListString: null, On 2017/05/02 20:25:28, Brian Wilkerson wrote: ...
3 years, 7 months ago (2017-05-02 20:48:25 UTC) #4
pquitslund
3 years, 7 months ago (2017-05-02 20:50:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a51af3846125848a6b14eb590c249539f9500740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698