Split up the if checks in ComputedStyle to make them easy to generate

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 999 matching lines @@
     // It's possible for the old and new style transform data to be equivalent
     // while hasTransform() differs, as it checks a number of conditions aside
     // from just the matrix, including but not limited to animation state.
     if (HasTransform() != other.HasTransform() ||
         !TransformDataEquivalent(other) ||
         rare_non_inherited_data_->perspective_ !=
             other.rare_non_inherited_data_->perspective_ ||
         rare_non_inherited_data_->perspective_origin_ !=
             other.rare_non_inherited_data_->perspective_origin_)
       diff.SetTransformChanged();
+  }
 
+  if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
     if (rare_non_inherited_data_->opacity !=
         other.rare_non_inherited_data_->opacity)
       diff.SetOpacityChanged();
+  }
 
+  if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
     if (rare_non_inherited_data_->filter_ !=
         other.rare_non_inherited_data_->filter_)
       diff.SetFilterChanged();
+  }
 
+  if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
     if (!rare_non_inherited_data_->ShadowDataEquivalent(
             *other.rare_non_inherited_data_.Get()))
       diff.SetNeedsRecomputeOverflow();
+  }
 
+  if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
     if (rare_non_inherited_data_->backdrop_filter_ !=
         other.rare_non_inherited_data_->backdrop_filter_)
       diff.SetBackdropFilterChanged();
+  }
 
+  if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
     if (!rare_non_inherited_data_->ReflectionDataEquivalent(
             *other.rare_non_inherited_data_.Get()))
       diff.SetFilterChanged();
+  }
 
+  if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
     if (!rare_non_inherited_data_->outline_.VisuallyEqual(
             other.rare_non_inherited_data_->outline_))
       diff.SetNeedsRecomputeOverflow();
   }
 
   if (!Border().VisualOverflowEqual(other.Border()))
     diff.SetNeedsRecomputeOverflow();
 
   if (!diff.NeedsFullPaintInvalidation()) {
     if (inherited_data_->color_ != other.inherited_data_->color_ ||
         inherited_data_->visited_link_color_ !=
             other.inherited_data_->visited_link_color_ ||
         HasSimpleUnderlineInternal() != other.HasSimpleUnderlineInternal() ||
         visual_data_->text_decoration != other.visual_data_->text_decoration) {
       diff.SetTextDecorationOrColorChanged();
-    } else if (rare_non_inherited_data_.Get() !=
-                   other.rare_non_inherited_data_.Get() &&
-               (rare_non_inherited_data_->text_decoration_style_ !=
-                    other.rare_non_inherited_data_->text_decoration_style_ ||
-                rare_non_inherited_data_->text_decoration_color_ !=
-                    other.rare_non_inherited_data_->text_decoration_color_ ||
-                rare_non_inherited_data_->visited_link_text_decoration_color_ !=
-                    other.rare_non_inherited_data_
-                        ->visited_link_text_decoration_color_)) {
-      diff.SetTextDecorationOrColorChanged();
-    } else if (rare_inherited_data_.Get() != other.rare_inherited_data_.Get() &&
-               (rare_inherited_data_->TextFillColor() !=
-                    other.rare_inherited_data_->TextFillColor() ||
-                rare_inherited_data_->TextStrokeColor() !=
-                    other.rare_inherited_data_->TextStrokeColor() ||
-                rare_inherited_data_->TextEmphasisColor() !=
-                    other.rare_inherited_data_->TextEmphasisColor() ||
-                rare_inherited_data_->VisitedLinkTextFillColor() !=
-                    other.rare_inherited_data_->VisitedLinkTextFillColor() ||
-                rare_inherited_data_->VisitedLinkTextStrokeColor() !=
-                    other.rare_inherited_data_->VisitedLinkTextStrokeColor() ||
-                rare_inherited_data_->VisitedLinkTextEmphasisColor() !=
-                    other.rare_inherited_data_
-                        ->VisitedLinkTextEmphasisColor() ||
-                rare_inherited_data_->text_emphasis_fill !=
-                    other.rare_inherited_data_->text_emphasis_fill ||
-                rare_inherited_data_->text_underline_position_ !=
-                    other.rare_inherited_data_->text_underline_position_ ||
-                rare_inherited_data_->text_decoration_skip_ !=
-                    other.rare_inherited_data_->text_decoration_skip_ ||
-                rare_inherited_data_->applied_text_decorations !=
-                    other.rare_inherited_data_->applied_text_decorations ||
-                rare_inherited_data_->CaretColor() !=
-                    other.rare_inherited_data_->CaretColor() ||
-                rare_inherited_data_->VisitedLinkCaretColor() !=
-                    other.rare_inherited_data_->VisitedLinkCaretColor())) {
-      diff.SetTextDecorationOrColorChanged();
+    } else {
+      if (rare_non_inherited_data_.Get() !=
+              other.rare_non_inherited_data_.Get() &&
+          (rare_non_inherited_data_->text_decoration_style_ !=
+               other.rare_non_inherited_data_->text_decoration_style_ ||
+           rare_non_inherited_data_->text_decoration_color_ !=
+               other.rare_non_inherited_data_->text_decoration_color_ ||
+           rare_non_inherited_data_->visited_link_text_decoration_color_ !=
+               other.rare_non_inherited_data_
+                   ->visited_link_text_decoration_color_)) {
+        diff.SetTextDecorationOrColorChanged();
+      }
+      if (rare_inherited_data_.Get() != other.rare_inherited_data_.Get() &&

[shend, 2017/05/04 01:04:04]

Not exactly the same behaviour as the original code. I think this should be
another else, with an if inside of it.

[nainar, 2017/05/04 01:08:56]

Yup. You're right. Wonder why this passes tests though. Low test coverage? Done
regardless

+          (rare_inherited_data_->TextFillColor() !=
+               other.rare_inherited_data_->TextFillColor() ||
+           rare_inherited_data_->TextStrokeColor() !=
+               other.rare_inherited_data_->TextStrokeColor() ||
+           rare_inherited_data_->TextEmphasisColor() !=
+               other.rare_inherited_data_->TextEmphasisColor() ||
+           rare_inherited_data_->VisitedLinkTextFillColor() !=
+               other.rare_inherited_data_->VisitedLinkTextFillColor() ||
+           rare_inherited_data_->VisitedLinkTextStrokeColor() !=
+               other.rare_inherited_data_->VisitedLinkTextStrokeColor() ||
+           rare_inherited_data_->VisitedLinkTextEmphasisColor() !=
+               other.rare_inherited_data_->VisitedLinkTextEmphasisColor() ||
+           rare_inherited_data_->text_emphasis_fill !=
+               other.rare_inherited_data_->text_emphasis_fill ||
+           rare_inherited_data_->text_underline_position_ !=
+               other.rare_inherited_data_->text_underline_position_ ||
+           rare_inherited_data_->text_decoration_skip_ !=
+               other.rare_inherited_data_->text_decoration_skip_ ||
+           rare_inherited_data_->applied_text_decorations !=
+               other.rare_inherited_data_->applied_text_decorations ||
+           rare_inherited_data_->CaretColor() !=
+               other.rare_inherited_data_->CaretColor() ||
+           rare_inherited_data_->VisitedLinkCaretColor() !=
+               other.rare_inherited_data_->VisitedLinkCaretColor())) {
+        diff.SetTextDecorationOrColorChanged();
+      }
     }
   }
 
   bool has_clip = HasOutOfFlowPosition() && !visual_data_->has_auto_clip;
   bool other_has_clip =
       other.HasOutOfFlowPosition() && !other.visual_data_->has_auto_clip;
   if (has_clip != other_has_clip ||
       (has_clip && visual_data_->clip != other.visual_data_->clip))
     diff.SetCSSClipChanged();
 }
@@ skipping 1394 matching lines @@
     if (value < 0)
       fvalue -= 0.5f;
     else
       fvalue += 0.5f;
   }
 
   return RoundForImpreciseConversion<int>(fvalue / zoom_factor);
 }
 
 }  // namespace blink