Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 2855853002: Don't update column position in StyleDidChange. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/relayout-out-of-flow-with-border-spacing.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp
index 39a9e325d72617e5e36baa46c59167bf1473ebe1..e7dfbd5d600d8bd73e9b0dd773b26d280807bc38 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp
@@ -83,7 +83,6 @@ void LayoutTable::StyleDidChange(StyleDifference diff,
// In the collapsed border model, there is no cell spacing.
h_spacing_ = ShouldCollapseBorders() ? 0 : Style()->HorizontalBorderSpacing();
mstensho (USE GERRIT) 2017/05/04 13:37:52 Furthermore, why are we updating h_spacing_ and v_
rune 2017/05/04 20:32:03 That sounds like a good idea, assuming LayoutTable
v_spacing_ = ShouldCollapseBorders() ? 0 : Style()->VerticalBorderSpacing();
- effective_column_positions_[0] = h_spacing_;
if (!table_layout_ ||
Style()->IsFixedTableLayout() != old_fixed_table_layout) {
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/relayout-out-of-flow-with-border-spacing.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698