Fix RTL URL rendering in Omnibox (domain off screen on long URL).

chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index c42d1c9bec8b0bf6cebb6d8b4acb3d2c1b65185c..90d81837e9d47ffaa75061600e01201b4ade45d8 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -1865,28 +1865,6 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, EditSearchEngines) {
   EXPECT_FALSE(omnibox_view->model()->popup_model()->IsOpen());
 }
 
-IN_PROC_BROWSER_TEST_F(OmniboxViewTest, BeginningShownAfterBlur) {

[Matt Giuca, 2017/05/18 08:41:12]

Sad... I had to delete this entire test. I think it's correct to do so.

What this test is testing (as far as I can tell, the only thing it really tests)
is that when you blur the Omnibox, it "shows the beginning" by setting the
selection range to [0, 0].

The bug that I am fixing here is that selecting [0, 0] doesn't necessarily show
the beginning, if your URL has RTL characters in it. So this test is
meaningless, it just tests that the old code does what it does.

The new code clears scrolling, and that's Views-specific. There's no way to test
that from here, because it relies on inspecting RenderText. So the new test in
omnibox_view_views_unittest.cc (OnBlur) tests that for Views specifically.

-  OmniboxView* omnibox_view = NULL;
-  ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
-
-  omnibox_view->OnBeforePossibleChange();
-  omnibox_view->SetWindowTextAndCaretPos(ASCIIToUTF16("data:text/plain,test"),
-      5U, false, false);
-  omnibox_view->OnAfterPossibleChange(true);
-  EXPECT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
-  size_t start, end;
-  omnibox_view->GetSelectionBounds(&start, &end);
-  EXPECT_EQ(5U, start);
-  EXPECT_EQ(5U, end);
-
-  ui_test_utils::FocusView(browser(), VIEW_ID_TAB_CONTAINER);
-  EXPECT_FALSE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
-
-  omnibox_view->GetSelectionBounds(&start, &end);
-  EXPECT_EQ(0U, start);
-  EXPECT_EQ(0U, end);
-}
-
 IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CtrlArrowAfterArrowSuggestions) {
   OmniboxView* omnibox_view = NULL;
   ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));