Fix RTL URL rendering in Omnibox (domain off screen on long URL).

chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/search_engines/template_url_service_factory_test_util.h"
 #include "chrome/browser/ui/omnibox/chrome_omnibox_client.h"
 #include "chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/omnibox/browser/omnibox_edit_model.h"
 #include "components/toolbar/test_toolbar_model.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/ime/text_edit_commands.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/keycodes/dom/dom_code.h"
+#include "ui/gfx/geometry/rect.h"
+#include "ui/gfx/geometry/vector2d.h"
+#include "ui/gfx/render_text.h"
 #include "ui/views/controls/textfield/textfield_test_api.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/input_method/input_method_configuration.h"
 #include "chrome/browser/chromeos/input_method/mock_input_method_manager_impl.h"
 #endif
 
 using gfx::Range;
 
 namespace {
 
 // TestingOmniboxView ---------------------------------------------------------
 
 class TestingOmniboxView : public OmniboxViewViews {
  public:
   enum BaseTextEmphasis {
     DEEMPHASIZED,
     EMPHASIZED,
     UNSET,
   };
 
   TestingOmniboxView(OmniboxEditController* controller,
                      std::unique_ptr<OmniboxClient> client,
                      CommandUpdater* command_updater);
 
   static BaseTextEmphasis to_base_text_emphasis(bool emphasize) {
     return emphasize ? EMPHASIZED : DEEMPHASIZED;
   }
 
+  using views::Textfield::GetRenderText;
+
   void ResetEmphasisTestState();
 
   void CheckUpdatePopupCallInfo(size_t call_count,
                                 const base::string16& text,
                                 const Range& selection_range);
 
   Range scheme_range() const { return scheme_range_; }
   Range emphasis_range() const { return emphasis_range_; }
   BaseTextEmphasis base_text_emphasis() const { return base_text_emphasis_; }
 
@@ skipping 222 matching lines @@
   omnibox_textfield()->SetTextEditCommandForNextKeyEvent(
       ui::TextEditCommand::MOVE_UP);
   EXPECT_EQ(ui::TextEditCommand::MOVE_UP, scheduled_text_edit_command());
 
   ui::KeyEvent up_pressed(ui::ET_KEY_PRESSED, ui::VKEY_UP, 0);
   omnibox_textfield()->OnKeyEvent(&up_pressed);
   EXPECT_EQ(ui::TextEditCommand::INVALID_COMMAND,
             scheduled_text_edit_command());
 }
 
+TEST_F(OmniboxViewViewsTest, OnBlur) {
+  // Make the Omnibox very narrow (so it couldn't fit the whole string).
+  int kOmniboxWidth = 60;
+  gfx::RenderText* render_text = omnibox_view()->GetRenderText();
+  render_text->SetDisplayRect(gfx::Rect(0, 0, kOmniboxWidth, 10));
+  render_text->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+
+  // (In this example, uppercase Latin letters represent Hebrew letters.)
+  // The string |kContentsRtl| is equivalent to:
+  //     RA.QWM/0123/abcd
+  // This is displayed as:
+  //     0123/MWQ.AR/abcd
+  // Enter focused mode, where the text should *not* be elided, and we expect
+  // SetWindowTextAndCaretPos to scroll such that the start of the string is
+  // on-screen. Because the domain is RTL, this scrolls to an offset greater
+  // than 0.
+  omnibox_view()->OnFocus();
+  const base::string16 kContentsRtl =
+      base::WideToUTF16(L"\x05e8\x05e2.\x05e7\x05d5\x05dd/0123/abcd");
+  static_cast<OmniboxView*>(omnibox_view())
+      ->SetWindowTextAndCaretPos(kContentsRtl, 0, false, false);
+  EXPECT_EQ(gfx::NO_ELIDE, render_text->elide_behavior());
+  // NOTE: Technically (depending on the font), this expectation could fail if
+  // the entire domain fits in 60 pixels. However, 60px is so small it should
+  // never happen with any font.
+  EXPECT_GT(0, render_text->GetUpdatedDisplayOffset().x());
+
+  // Now enter blurred mode, where the text should be elided to 60px. This means
+  // the string itself is truncated. Scrolling would therefore mean the text is
+  // off-screen. Ensure that the horizontal scrolling has been reset to 0.
+  omnibox_view()->OnBlur();
+  EXPECT_EQ(gfx::ELIDE_TAIL, render_text->elide_behavior());
+  EXPECT_EQ(0, render_text->GetUpdatedDisplayOffset().x());
+}
+
 TEST_F(OmniboxViewViewsTest, Emphasis) {
   constexpr struct {
     const char* input;
     bool expected_base_text_emphasized;
     Range expected_emphasis_range;
     Range expected_scheme_range;
   } test_cases[] = {
       {"data:text/html,Hello%20World", false, Range(0, 4), Range(0, 4)},
       {"http://www.example.com/path/file.htm", false, Range(7, 22),
        Range(0, 4)},
@@ skipping 25 matching lines @@
       EXPECT_EQ(TestingOmniboxView::to_base_text_emphasis(
                     test_case.expected_base_text_emphasized),
                 omnibox_view()->base_text_emphasis());
       EXPECT_EQ(test_case.expected_emphasis_range,
                 omnibox_view()->emphasis_range());
       EXPECT_EQ(test_case.expected_scheme_range,
                 omnibox_view()->scheme_range());
     }
   }
 }