Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 2855753002: Simplify HTMLPlugInElement::PluginWrapper to not use SharedPersistent. (Closed)
Patch Set: no need for mutable Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index 8f03da4fe08d79e3a69f87743a86a5ce465c4aad..f1c65dacf7115aa064e955e5310a1a05aaa39b28 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -182,18 +182,6 @@ void ScriptController::DisableEval(const String& error_message) {
V8String(GetIsolate(), error_message));
}
-PassRefPtr<SharedPersistent<v8::Object>> ScriptController::CreatePluginWrapper(
- PluginView& plugin) {
- v8::HandleScope handle_scope(GetIsolate());
- v8::Local<v8::Object> scriptable_object =
- plugin.ScriptableObject(GetIsolate());
-
- if (scriptable_object.IsEmpty())
- return nullptr;
-
- return SharedPersistent<v8::Object>::Create(scriptable_object, GetIsolate());
-}
-
V8Extensions& ScriptController::RegisteredExtensions() {
DEFINE_STATIC_LOCAL(V8Extensions, extensions, ());
return extensions;

Powered by Google App Engine
This is Rietveld 408576698