Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2855733002: Make ClassicPendingScript always become ready asynchronously.

Created:
3 years, 7 months ago by jbroman
Modified:
3 years, 5 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, loading-reviews+parser_chromium.org, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ClassicPendingScript always become ready asynchronously. This prevents the main thread from blocking for a series of scripts consecutively a number of them are all available together (esp. when served from the cache). This gives the scheduler the opportunity to schedule higher priority work in this or other tabs rather than continuing to block the thread. BUG=591558 --- moved to https://chromium-review.googlesource.com/551276 ---

Patch Set 1 #

Patch Set 2 : revert trace events and stuff #

Patch Set 3 : . #

Patch Set 4 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/local-JavaScript-from-remote.html View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/local-JavaScript-from-remote-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 2 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 15 (15 generated)
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 20:44:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855733002/1
3 years, 7 months ago (2017-05-01 20:44:49 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 20:49:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855733002/20001
3 years, 7 months ago (2017-05-01 20:49:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-01 22:30:46 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/416300)
3 years, 7 months ago (2017-05-01 22:30:47 UTC) #6
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-10 20:16:23 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855733002/40001
3 years, 7 months ago (2017-05-10 20:17:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-10 21:34:32 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/423300)
3 years, 7 months ago (2017-05-10 21:34:33 UTC) #10
jbroman
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-11 18:43:35 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855733002/60001
3 years, 7 months ago (2017-05-11 18:44:25 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-11 19:51:30 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/451290)
3 years, 7 months ago (2017-05-11 19:51:31 UTC) #14
jbroman
3 years, 5 months ago (2017-06-28 00:33:35 UTC) #15 
Description was changed from

==========
Make ClassicPendingScript always become ready asynchronously.

This prevents the main thread from blocking for a series of scripts
consecutively a number of them are all available together (esp. when served
from the cache).

This gives the scheduler the opportunity to schedule higher priority work
in this or other tabs rather than continuing to block the thread.

BUG=591558
==========

to

==========
Make ClassicPendingScript always become ready asynchronously.

This prevents the main thread from blocking for a series of scripts
consecutively a number of them are all available together (esp. when served
from the cache).

This gives the scheduler the opportunity to schedule higher priority work
in this or other tabs rather than continuing to block the thread.

BUG=591558

--- moved to https://chromium-review.googlesource.com/551276 ---
==========

Powered by Google App Engine
This is Rietveld 408576698