Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: cc/test/fake_compositor_frame_sink.cc

Issue 2855723002: Don't submit frames with no render passes in cc tests (Closed)
Patch Set: c Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/fake_compositor_frame_sink.h ('k') | services/ui/public/cpp/client_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/fake_compositor_frame_sink.cc
diff --git a/cc/test/fake_compositor_frame_sink.cc b/cc/test/fake_compositor_frame_sink.cc
index b287eea23ac965f31a58879729e6d250df6a76bb..81746a72b8cd482f8f459e11c9c764299712b445 100644
--- a/cc/test/fake_compositor_frame_sink.cc
+++ b/cc/test/fake_compositor_frame_sink.cc
@@ -52,13 +52,7 @@ void FakeCompositorFrameSink::SubmitCompositorFrame(CompositorFrame frame) {
last_sent_frame_.reset(new CompositorFrame(std::move(frame)));
++num_sent_frames_;
- if (!last_sent_frame_->render_pass_list.empty()) {
- last_swap_rect_ = last_sent_frame_->render_pass_list.back()->damage_rect;
- last_swap_rect_valid_ = true;
- } else {
- last_swap_rect_ = gfx::Rect();
- last_swap_rect_valid_ = false;
- }
+ last_swap_rect_ = last_sent_frame_->render_pass_list.back()->damage_rect;
resources_held_by_parent_.insert(resources_held_by_parent_.end(),
last_sent_frame_->resource_list.begin(),
« no previous file with comments | « cc/test/fake_compositor_frame_sink.h ('k') | services/ui/public/cpp/client_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698