Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2855603002: Update verifier to correctly analyze types of fields. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
Reviewers:
asgerf, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update verifier to correctly analyze types of fields. Fixes #29511. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/5d08d5bb6cdf169b4c9d534808477cf7042bf8c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/kernel/lib/verifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkg.status View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahe
3 years, 7 months ago (2017-05-01 14:56:12 UTC) #3
Paul Berry
lgtm Thanks!
3 years, 7 months ago (2017-05-01 15:02:00 UTC) #4
ahe
3 years, 7 months ago (2017-05-01 15:26:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d08d5bb6cdf169b4c9d534808477cf7042bf8c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698