Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2855593002: Revert "Move JsInteropAnalysis.onQueueClosed to AnnotationProcessor.processJsInteropAnnotation" (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Move JsInteropAnalysis.onQueueClosed to AnnotationProcessor.processJsInteropAnnotation" This reverts commit 86671fdd56e1163c2e5e1baa77017f43205adb07. Committed: https://github.com/dart-lang/sdk/commit/9a1460dc439dcac68e9c2de456e305ee82eea85d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -187 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/frontend_strategy.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 2 chunks +172 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 7 chunks +0 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 3 chunks +0 lines, -147 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
Johnni Winther
TBR
3 years, 7 months ago (2017-05-01 13:11:57 UTC) #2
Johnni Winther
3 years, 7 months ago (2017-05-01 13:12:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a1460dc439dcac68e9c2de456e305ee82eea85d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698