Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2855573003: [Gardening] Mark 2 layout tests as failing (Closed)

Created:
3 years, 7 months ago by kustermann
Modified:
3 years, 7 months ago
CC:
reviews+dom_dartlang.org, terry
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Gardening] Mark 2 layout tests as failing BUG=https://github.com/dart-lang/sdk/issues/29514 R=jacobr@google.com, vegorov@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=6b2be51884a122443c468e93e9d5090fb709964b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/dart/inspector/debugger-eval-on-call-frame-expected.txt View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/dart/inspector/evaluate-in-console-expected.txt View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kustermann
3 years, 7 months ago (2017-05-01 13:16:07 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 7 months ago (2017-05-01 13:33:59 UTC) #3
Jacob
lgtm
3 years, 7 months ago (2017-05-01 15:09:14 UTC) #5
kustermann
3 years, 7 months ago (2017-05-01 15:46:20 UTC) #6
@Jacob: As mentioned on the github issue, I don't seem to have permission to
land the CL. Feel free to do that for me.

Powered by Google App Engine
This is Rietveld 408576698