third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp - Issue 2855523002: Deleted Widget/FrameViewBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

Issue 2855523002: Deleted Widget/FrameViewBase (Closed)

Patch Set: update comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp b/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

index aad4568c60ffca70a2c55681c72fabf18b4743b2..8198f38043bf397e4bae86275640ba1534bdafc6 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp

@@ -160,7 +160,7 @@ ScrollbarPart ScrollbarTheme::HitTest(const ScrollbarThemeClient& scrollbar,

return result;

IntPoint test_position =

- scrollbar.ConvertFromRootFrame(position_in_root_frame);

+ scrollbar.ConvertPointFromRootFrame(position_in_root_frame);

test_position.Move(scrollbar.X(), scrollbar.Y());

if (!scrollbar.FrameRect().Contains(test_position))

@@ -275,7 +275,7 @@ void ScrollbarTheme::PaintTickmarks(GraphicsContext& context,

bool ScrollbarTheme::ShouldSnapBackToDragOrigin(

const ScrollbarThemeClient& scrollbar,

const WebMouseEvent& evt) {

- IntPoint mouse_position = scrollbar.ConvertFromRootFrame(

+ IntPoint mouse_position = scrollbar.ConvertPointFromRootFrame(

FlooredIntPoint(evt.PositionInRootFrame()));

mouse_position.Move(scrollbar.X(), scrollbar.Y());

return Platform::Current()->ScrollbarBehavior()->ShouldSnapBackToDragOrigin(