third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2855523002: Deleted Widget/FrameViewBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2855523002: Deleted Widget/FrameViewBase (Closed)

Patch Set: Keep FrameViewBase.h file until dependent CL is landed. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 19ba8212468a085d68c85d4f6d76871c4c7039a9..1ef3155b502b9dc090bee3453f707ede30a31a5e 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -88,9 +88,8 @@ class PagePopupChromeClient final : public EmptyChromeClient {

IntRect RootWindowRect() override { return popup_->WindowRectInScreen(); }

- IntRect ViewportToScreen(

- const IntRect& rect,

- const FrameViewBase* frame_view_base) const override {

+ IntRect ViewportToScreen(const IntRect& rect,

+ const FrameView* frame_view) const override {

WebRect rect_in_screen(rect);

WebRect window_rect = popup_->WindowRectInScreen();

popup_->WidgetClient()->ConvertViewportToWindow(&rect_in_screen);