ui/native_theme/native_theme_win.cc - Issue 2855503003: Replace uses of legacy SkBitmap::copyTo() API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/native_theme_win.cc

Issue 2855503003: Replace uses of legacy SkBitmap::copyTo() API (Closed)

Patch Set: Remove braces Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/native_theme/native_theme_win.cc

diff --git a/ui/native_theme/native_theme_win.cc b/ui/native_theme/native_theme_win.cc

index adc73210bbb471d61e78038d6a6080cabe440473..4cc33417c5a61d385c1ea7b55a75c9a4508b5502 100644

--- a/ui/native_theme/native_theme_win.cc

+++ b/ui/native_theme/native_theme_win.cc

@@ -75,7 +75,8 @@ void SetCheckerboardShader(SkPaint* paint, const RECT& align_rect) {

SkBitmap temp_bitmap;

temp_bitmap.installPixels(info, buffer, info.minRowBytes());

SkBitmap bitmap;

- temp_bitmap.copyTo(&bitmap);

+ if (bitmap.tryAllocPixels(info))

+ temp_bitmap.readPixels(info, bitmap.getPixels(), bitmap.rowBytes(), 0, 0);

// Align the pattern with the upper corner of |align_rect|.

SkMatrix local_matrix;

« no previous file with comments | « ui/base/test/test_clipboard.cc ('k') | no next file » | no next file with comments »