chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc - Issue 2855503003: Replace uses of legacy SkBitmap::copyTo() API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

Issue 2855503003: Replace uses of legacy SkBitmap::copyTo() API (Closed)

Patch Set: Remove braces Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bitmap_fetcher/bitmap_fetcher_browsertest.cc ('k') | chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

diff --git a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

index ae08305aba940c292907ab7a805d06327fb85ce2..eff5d5f1e192a04912592299c066359af8c796fe 100644

--- a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

+++ b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

@@ -81,12 +81,18 @@ class AccessibilityHighlightManagerTest : public InProcessBrowserTest {

void CaptureBeforeImage(const gfx::Rect& bounds) {

Capture(bounds);

- image_.AsBitmap().deepCopyTo(&before_bmp_);

+ if (before_bmp_.tryAllocPixels(image_.AsBitmap().info())) {

+ image_.AsBitmap().readPixels(before_bmp_.info(), before_bmp_.getPixels(),

+ before_bmp_.rowBytes(), 0, 0);

+ }

}

void CaptureAfterImage(const gfx::Rect& bounds) {

Capture(bounds);

- image_.AsBitmap().deepCopyTo(&after_bmp_);

+ if (after_bmp_.tryAllocPixels(image_.AsBitmap().info())) {

+ image_.AsBitmap().readPixels(after_bmp_.info(), after_bmp_.getPixels(),

+ after_bmp_.rowBytes(), 0, 0);

+ }

}

void ComputeImageStats() {