[Media Router] Sync state when MR extension is (re)connected to MR.

chrome/browser/media/router/mojo/media_router_mojo_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/mojo/media_router_mojo_impl.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 135 matching lines @@
     SetWakeReason(MediaRouteProviderWakeReason::REGISTER_MEDIA_ROUTE_PROVIDER);
     AttemptWakeEventPage();
     return;
   }
 
   media_route_provider_ = std::move(media_route_provider_ptr);
   media_route_provider_.set_connection_error_handler(base::Bind(
       &MediaRouterMojoImpl::OnConnectionError, base::Unretained(this)));
   callback.Run(instance_id_);
   ExecutePendingRequests();
+  EnsureMediaRouteProviderStateSynced();
+
   wakeup_attempt_count_ = 0;
-#if defined(OS_WIN)
-  // The MRPM extension already turns on mDNS discovery for platforms other than
-  // Windows. It only relies on this signalling from MR on Windows to avoid
-  // triggering a firewall prompt out of the context of MR from the user's
-  // perspective. This particular call reminds the extension to enable mDNS
-  // discovery when it wakes up, has been upgraded, etc.
-  if (should_enable_mdns_discovery_) {
-    DoEnsureMdnsDiscoveryEnabled();
-  }
-#endif
 }
 
 void MediaRouterMojoImpl::OnIssue(const IssueInfo& issue) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DVLOG_WITH_INSTANCE(1) << "OnIssue " << issue.title;
   issue_manager_.AddIssue(issue);
 }
 
 void MediaRouterMojoImpl::OnSinksReceived(
     const std::string& media_source,
@@ skipping 662 matching lines @@
 }
 
 void MediaRouterMojoImpl::DoStartObservingMediaSinks(
     const MediaSource::Id& source_id) {
   DVLOG_WITH_INSTANCE(1) << "DoStartObservingMediaSinks: " << source_id;
   // No need to call MRPM if there are no sinks available.
   if (availability_ == mojom::MediaRouter::SinkAvailability::UNAVAILABLE)
     return;
 
   // No need to call MRPM if all observers have been removed in the meantime.
-  auto* sinks_query = sinks_queries_[source_id].get();
-  if (!sinks_query || !sinks_query->observers.might_have_observers())
+  auto it = sinks_queries_.find(source_id);
+  if (it == sinks_queries_.end() ||
+      !it->second->observers.might_have_observers())
     return;
 
   DVLOG_WITH_INSTANCE(1) << "MRPM.StartObservingMediaSinks: " << source_id;
   media_route_provider_->StartObservingMediaSinks(source_id);
-  sinks_query->is_active = true;
+  it->second->is_active = true;
 }
 
 void MediaRouterMojoImpl::DoStopObservingMediaSinks(
     const MediaSource::Id& source_id) {
   DVLOG_WITH_INSTANCE(1) << "DoStopObservingMediaSinks: " << source_id;
 
   auto it = sinks_queries_.find(source_id);
   // No need to call MRPM if observers have been added in the meantime,
   // or StopObservingMediaSinks has already been called.
   if (it == sinks_queries_.end() || !it->second->is_active ||
@@ skipping 11 matching lines @@
   DVLOG_WITH_INSTANCE(1) << "DoStartObservingMediaRoutes";
 
   // No need to call MRPM if all observers have been removed in the meantime.
   auto it = routes_queries_.find(source_id);
   if (it == routes_queries_.end() ||
       !it->second->observers.might_have_observers())
     return;
 
   DVLOG_WITH_INSTANCE(1) << "MRPM.StartObservingMediaRoutes: " << source_id;
   media_route_provider_->StartObservingMediaRoutes(source_id);
-  it->second->is_active = true;
 }
 
 void MediaRouterMojoImpl::DoStopObservingMediaRoutes(
     const MediaSource::Id& source_id) {
   DVLOG_WITH_INSTANCE(1) << "DoStopObservingMediaRoutes";
 
   // No need to call MRPM if observers have been added in the meantime,
   // or StopObservingMediaRoutes has already been called.
   auto it = routes_queries_.find(source_id);
-  if (it == routes_queries_.end() || !it->second->is_active ||
+  if (it == routes_queries_.end() ||
       it->second->observers.might_have_observers()) {
     return;
   }
 
   DVLOG_WITH_INSTANCE(1) << "MRPM.StopObservingMediaRoutes: " << source_id;
   media_route_provider_->StopObservingMediaRoutes(source_id);
   routes_queries_.erase(source_id);
 }
 
 void MediaRouterMojoImpl::EnqueueTask(base::OnceClosure closure) {
@@ skipping 59 matching lines @@
   DCHECK(media_route_provider_);
   DCHECK(event_page_tracker_);
   DCHECK(!media_route_provider_extension_id_.empty());
 
   for (auto& next_request : pending_requests_)
     std::move(next_request).Run();
 
   pending_requests_.clear();
 }
 
+void MediaRouterMojoImpl::EnsureMediaRouteProviderStateSynced() {
+  DCHECK(media_route_provider_);
+
+  // Sink queries.
+  if (availability_ != mojom::MediaRouter::SinkAvailability::UNAVAILABLE) {
+    for (const auto& it : sinks_queries_) {
+      DoStartObservingMediaSinks(it.first);
+    }
+  }
+
+  // Route queries.
+  for (const auto& it : routes_queries_) {
+    DoStartObservingMediaRoutes(it.first);
+  }
+
+  // Route messages.
+  for (const auto& it : message_observers_) {
+    DoStartListeningForRouteMessages(it.first);
+  }
+
+#if defined(OS_WIN)
+  // The MRPM extension already turns on mDNS discovery for platforms other than
+  // Windows. It only relies on this signalling from MR on Windows to avoid
+  // triggering a firewall prompt out of the context of MR from the user's
+  // perspective. This particular call reminds the extension to enable mDNS
+  // discovery when it wakes up, has been upgraded, etc.
+  if (should_enable_mdns_discovery_) {
+    DoEnsureMdnsDiscoveryEnabled();

[mark a. foltz, 2017/05/03 17:37:08]

Would prefer DoEnableMdnsDiscovery(), but not necessary to change in this patch.

[imcheng, 2017/05/03 18:22:41]

Acknowledged.

+  }
+#endif
+}
+
 void MediaRouterMojoImpl::EventPageWakeComplete(bool success) {
   if (success) {
     MediaRouterMojoMetrics::RecordMediaRouteProviderWakeReason(
         current_wake_reason_);
     ClearWakeReason();
     MediaRouterMojoMetrics::RecordMediaRouteProviderWakeup(
         MediaRouteProviderWakeup::SUCCESS);
     return;
   }
 
@@ skipping 78 matching lines @@
 
 void MediaRouterMojoImpl::OnMediaControllerCreated(
     const MediaRoute::Id& route_id,
     bool success) {
   // TODO(takumif): Record success/failure with UMA.
   DVLOG_WITH_INSTANCE(1) << "OnMediaControllerCreated: " << route_id
                          << (success ? " was successful." : " failed.");
 }
 
 }  // namespace media_router