Recognize List constructor and turn it into CreateArray ...

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/bit_vector.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
@@ skipping 393 matching lines @@
     }
   }
 
   return true;
 }
 
 
 static bool CompareNames(const Library& lib,
                          const char* test_name,
                          const String& name) {
+  ASSERT(Library::kPrivateIdentifierStart == '_');
   const char* kPrivateGetterPrefix = "get:_";
   const char* kPrivateSetterPrefix = "set:_";
 
-  if (test_name[0] == '_') {
-    if (name.CharAt(0) != '_') {
+  if (test_name[0] == Library::kPrivateIdentifierStart) {
+    if (name.CharAt(0) != Library::kPrivateIdentifierStart) {
       return false;
     }
   } else if (strncmp(test_name,
                      kPrivateGetterPrefix,
                      strlen(kPrivateGetterPrefix)) == 0) {
     if (!StartsWith(name, kPrivateGetterPrefix, strlen(kPrivateGetterPrefix))) {
       return false;
     }
   } else if (strncmp(test_name,
                      kPrivateSetterPrefix,
                      strlen(kPrivateSetterPrefix)) == 0) {
     if (!StartsWith(name, kPrivateSetterPrefix, strlen(kPrivateSetterPrefix))) {
       return false;
     }
   } else {
     // Compare without mangling.
     return name.Equals(test_name);
   }
 
   // Both names are private. Mangle test_name before comparison.
-  const String& test_name_symbol = String::Handle(Symbols::New(test_name));
-  return String::Handle(lib.PrivateName(test_name_symbol)).Equals(name);
+  // Check if this is a constructor (e.g., List,), in which case the mangler
+  // needs some help (see comment in Library::PrivateName).
+  String& test_name_symbol = String::Handle();
+  if (test_name[strlen(test_name) - 1] == '.') {
+    test_name_symbol = Symbols::New(test_name, strlen(test_name) - 1);
+    test_name_symbol = lib.PrivateName(test_name_symbol);
+    test_name_symbol = String::Concat(test_name_symbol, Symbols::Dot());
+  } else {
+    test_name_symbol = Symbols::New(test_name);
+    test_name_symbol = lib.PrivateName(test_name_symbol);
+  }
+  return test_name_symbol.Equals(name);
 }
 
 
 static bool IsRecognizedLibrary(const Library& library) {
   // List of libraries where methods can be recognized.
   return (library.raw() == Library::CoreLibrary())
       || (library.raw() == Library::MathLibrary())
       || (library.raw() == Library::TypedDataLibrary())
       || (library.raw() == Library::InternalLibrary());
 }
@@ skipping 2962 matching lines @@
     case Token::kTRUNCDIV: return 0;
     case Token::kMOD: return 1;
     default: UNIMPLEMENTED(); return -1;
   }
 }
 
 
 #undef __
 
 }  // namespace dart