Recognize List constructor and turn it into CreateArray ...

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 80 matching lines @@
 }
 
 
 // Allocation of a fixed length array of given element type.
 // This runtime entry is never called for allocating a List of a generic type,
 // because a prior run time call instantiates the element type if necessary.
 // Arg0: array length.
 // Arg1: array type arguments, i.e. vector of 1 type, the element type.
 // Return value: newly allocated array of length arg0.
 DEFINE_RUNTIME_ENTRY(AllocateArray, 2) {
-  const Smi& length = Smi::CheckedHandle(arguments.ArgAt(0));
-  const Array& array = Array::Handle(Array::New(length.Value()));
+  const Instance& length = Instance::CheckedHandle(arguments.ArgAt(0));
+  if (!length.IsSmi()) {
+    const String& error = String::Handle(String::NewFormatted(
+        "Length must be an integer in the range [0..%" Pd "].",
+        Array::kMaxElements));
+    Exceptions::ThrowArgumentError(error);
+  }
+  const intptr_t len = Smi::Cast(length).Value();
+  if (len < 0) {
+    const String& error = String::Handle(String::NewFormatted(
+        "Length (%" Pd ") must be an integer in the range [0..%" Pd "].",
+        len, Array::kMaxElements));
+    Exceptions::ThrowArgumentError(error);
+  }
+
+  const Array& array = Array::Handle(Array::New(len));
   arguments.SetReturn(array);
   TypeArguments& element_type =
       TypeArguments::CheckedHandle(arguments.ArgAt(1));
   // An Array is raw or takes one type argument. However, its type argument
   // vector may be longer than 1 due to a type optimization reusing the type
   // argument vector of the instantiator.
   ASSERT(element_type.IsNull() ||
          ((element_type.Length() >= 1) && element_type.IsInstantiated()));
   array.SetTypeArguments(element_type);  // May be null.
 }
@@ skipping 1405 matching lines @@
 // of the given value.
 //   Arg0: Field object;
 //   Arg1: Value that is being stored.
 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
   const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
   const Object& value = Object::Handle(arguments.ArgAt(1));
   field.UpdateGuardedCidAndLength(value);
 }
 
 }  // namespace dart