Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: pdf/out_of_process_instance.h

Issue 2855423002: Use more StringPieces in the PDF plugin. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/DEPS ('k') | pdf/out_of_process_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/out_of_process_instance.h
diff --git a/pdf/out_of_process_instance.h b/pdf/out_of_process_instance.h
index f2435bc69c4ea6f34592e04e61775aea2b0bd2e1..54058a48430efb6e6a953f32158a039bc94d5b81 100644
--- a/pdf/out_of_process_instance.h
+++ b/pdf/out_of_process_instance.h
@@ -204,9 +204,9 @@ class OutOfProcessInstance : public pp::Instance,
// Process the preview page data information. |src_url| specifies the preview
// page data location. The |src_url| is in the format:
// chrome://print/id/page_number/print.pdf
- // |dst_page_index| specifies the blank page index that needs to be replaced
Lei Zhang 2017/05/04 19:19:38 We might have chosen "dst" because it's the same l
+ // |dest_page_index| specifies the blank page index that needs to be replaced
// with the new page data.
- void ProcessPreviewPageInfo(const std::string& src_url, int dst_page_index);
+ void ProcessPreviewPageInfo(const std::string& src_url, int dest_page_index);
// Load the next available preview page into the blank page.
void LoadAvailablePreviewPage();
« no previous file with comments | « pdf/DEPS ('k') | pdf/out_of_process_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698