Type inference for StringConcatenation.

Type inference for StringConcatenation.

The test simple_literal_string was replaced with string_literal.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9a34ac9f275f10aabdc7921e19e22a0ec9ca3cf7

[Paul Berry, 2017-05-04 15:34:52]

https://codereview.chromium.org/2855403002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/2855403002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:251: DartType
typeContext, bool typeNeeded, List<E> expressions) {
Since the only thing we need to do with [expressions] is iterate through it,
let's make its type `Iterable<E>`.

https://codereview.chromium.org/2855403002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:253:
inferExpression(expression, typeContext, typeNeeded);
This should be:

inferExpression(expression, null, false);

The `null` ensures that subexpressions don't get forced to be strings (it's ok
if they aren't because toString is implicitly called on them), and the `false`
indicates that we won't be using the return value of `inferExpression`.

[Paul Berry, 2017-05-04 15:39:09]

Assuming the above changes are made, lgtm

[scheglov, 2017-05-04 15:40:37]

https://codereview.chromium.org/2855403002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart (right):

https://codereview.chromium.org/2855403002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:251: DartType
typeContext, bool typeNeeded, List<E> expressions) {
On 2017/05/04 15:34:52, Paul Berry wrote:
> Since the only thing we need to do with [expressions] is iterate through it,
> let's make its type `Iterable<E>`.

Done.

https://codereview.chromium.org/2855403002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart:253:
inferExpression(expression, typeContext, typeNeeded);
On 2017/05/04 15:34:52, Paul Berry wrote:
> This should be:
> 
> inferExpression(expression, null, false);
> 
> The `null` ensures that subexpressions don't get forced to be strings (it's ok
> if they aren't because toString is implicitly called on them), and the `false`
> indicates that we won't be using the return value of `inferExpression`.

Done.

[scheglov, 2017-05-04 15:47:14]

Description was changed from

==========
Type inference for StringConcatenation.

The test simple_literal_string was replaced with string_literal.

R=paulberry@google.com
BUG=
==========

to

==========
Type inference for StringConcatenation.

The test simple_literal_string was replaced with string_literal.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9a34ac9f275f10aabdc7921e19e22a0ec9ca3cf7
==========

[scheglov, 2017-05-04 15:47:16]

Committed patchset #2 (id:20001) manually as
9a34ac9f275f10aabdc7921e19e22a0ec9ca3cf7 (presubmit successful).