content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java - Issue 2855353002: Make Paste Popup use selection rect for positioning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java

Issue 2855353002: Make Paste Popup use selection rect for positioning (Closed)

Patch Set: fix typo Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java b/content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java

index fc8ba7fdc81a979cdb7a76e3b699e486cd571ad1..f3493c581d68e85e20a2eeec5909e21618fa63b1 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java

@@ -6,6 +6,7 @@ package org.chromium.content.browser.input;

import android.content.Context;

import android.content.res.TypedArray;

+import android.graphics.Rect;

import android.util.TypedValue;

import android.view.Gravity;

import android.view.LayoutInflater;

@@ -68,10 +69,10 @@ public class LegacyPastePopupMenu implements OnClickListener, PastePopupMenu {

}

@Override

- public void show(int x, int y) {

+ public void show(Rect selectionRect) {

hide();

updateContent();

- positionAt(x, y);

+ positionAt(selectionRect.left, selectionRect.bottom);

}

@Override