Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2855353002: Make Paste Popup use selection rect for positioning (Closed)
Patch Set: fix typo Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/android/selection_popup_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 761677293524eb653fff0bf6ed1eb89be91a1eca..67124be7f32e6a85c73c3b533a24a7640952f4fa 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -601,9 +601,12 @@ bool ContentViewCoreImpl::ShowPastePopup(const ContextMenuParams& params) {
const bool can_edit_richly =
!!(params.edit_flags & blink::WebContextMenuData::kCanEditRichly);
- Java_ContentViewCore_showPastePopup(env, obj, params.selection_start.x(),
- params.selection_start.y(),
- can_select_all, can_edit_richly);
+ int handle_height = GetRenderWidgetHostViewAndroid()->GetTouchHandleHeight();
+ Java_ContentViewCore_showPastePopup(
+ env, obj, params.selection_rect.x(), params.selection_rect.y(),
+ params.selection_rect.right(),
+ params.selection_rect.bottom() + handle_height, can_select_all,
+ can_edit_richly);
return true;
}
« no previous file with comments | « no previous file | content/browser/android/selection_popup_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698