Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2855353002: Make Paste Popup use selection rect for positioning (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index ff488741db1997fee661106571a7f1408ec9f566..72aca6d2dd003e19f4fc0327344d23b2aba38480 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4332,14 +4332,9 @@ void RenderFrameImpl::ShowContextMenu(const blink::WebContextMenuData& data) {
if (params.src_url.spec().size() > url::kMaxURLChars)
params.src_url = GURL();
-#if defined(OS_ANDROID)
- gfx::Rect start_rect;
- gfx::Rect end_rect;
- GetRenderWidget()->GetSelectionBounds(&start_rect, &end_rect);
- params.selection_start = gfx::Point(start_rect.x(), start_rect.bottom());
- params.selection_end = gfx::Point(end_rect.right(), end_rect.bottom());
-#endif
-
+ blink::WebRect selection_in_window(data.selection_rect);
+ GetRenderWidget()->ConvertViewportToWindow(&selection_in_window);
+ params.selection_rect = selection_in_window;
Send(new FrameHostMsg_ContextMenu(routing_id_, params));
}

Powered by Google App Engine
This is Rietveld 408576698