Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: net/url_request/url_request.cc

Issue 2855343002: Remove some TODOs. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index bcddd10563394e9534dd525f888915c05b734352..a96749855278cbdab7bb1ad8c60bba452e0bcc7d 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -801,7 +801,6 @@ void URLRequest::NotifyReceivedRedirect(const RedirectInfo& redirect_info,
bool* defer_redirect) {
is_redirecting_ = true;
- // TODO(davidben): Pass the full RedirectInfo down to MaybeInterceptRedirect?
URLRequestJob* job =
URLRequestJobManager::GetInstance()->MaybeInterceptRedirect(
this, network_delegate_, redirect_info.new_url);
@@ -925,7 +924,6 @@ int URLRequest::Redirect(const RedirectInfo& redirect_info) {
&redirect_info.new_url.possibly_invalid_spec()));
}
- // TODO(davidben): Pass the full RedirectInfo to the NetworkDelegate.
if (network_delegate_)
network_delegate_->NotifyBeforeRedirect(this, redirect_info.new_url);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698