pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart - Issue 2855323004: Infer VariableSet types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

Issue 2855323004: Infer VariableSet types. (Closed)

Patch Set: Fixes for review comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

index 8b306a6c7ef3e8dafb06f13efd2829e532de62ef..51027e42dd3d9dfcbc2a9cfd5207052bdeb992d0 100644

--- a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

@@ -173,7 +173,7 @@ abstract class VariableAccessor extends Accessor {

helper.typePromoter.mutateVariable(variable, helper.functionNestingLevel);

return variable.isFinal || variable.isConst

? makeInvalidWrite(value)

- : new VariableSet(variable, value)

+ : helper.astFactory.variableSet(variable, value)

..fileOffset = offsetForToken(token);

}