Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: Source/core/css/StyleSheetContentsCache.h

Issue 28553005: Avoid parsing css text if there are identical inline style blocks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Added StyleSheetContentsCache class Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2013 Google Inc. All rights reserved. 4 * Copyright (C) 2013 Google Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
11 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 14 * Library General Public License for more details.
15 * 15 *
16 * You should have received a copy of the GNU Library General Public License 16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to 17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA. 19 * Boston, MA 02110-1301, USA.
20 * 20 *
21 */ 21 */
22 22
23 #ifndef MatchedPropertiesCache_h 23 #ifndef StyleSheetContentsCache_h
24 #define MatchedPropertiesCache_h 24 #define StyleSheetContentsCache_h
25 25
26 #include "core/css/resolver/MatchResult.h" 26 #include "core/css/StyleSheetContents.h"
27
28 #include "platform/Timer.h" 27 #include "platform/Timer.h"
29 #include "wtf/Forward.h" 28 #include "wtf/Forward.h"
30 #include "wtf/HashMap.h" 29 #include "wtf/HashMap.h"
31 #include "wtf/Noncopyable.h" 30 #include "wtf/Noncopyable.h"
31 #include "wtf/RefPtr.h"
32 #include "wtf/text/AtomicString.h"
32 33
33 namespace WebCore { 34 namespace WebCore {
34 35
35 class RenderStyle; 36 class StyleSheetContents;
36 class StyleResolverState;
37 37
38 struct CachedMatchedProperties { 38 class CachedStyleSheetContents {
dglazkov 2013/10/21 18:24:10 StyleSheetContentsCacheItem?
tasak 2013/10/25 05:23:13 Done.
39 Vector<MatchedProperties> matchedProperties; 39 public:
40 MatchRanges ranges; 40 static PassOwnPtr<CachedStyleSheetContents> create(StyleSheetContents*);
41 RefPtr<RenderStyle> renderStyle;
42 RefPtr<RenderStyle> parentRenderStyle;
43 41
44 void set(const RenderStyle*, const RenderStyle* parentStyle, const MatchResu lt&); 42 unsigned addref() { return ++m_refCount; }
45 void clear(); 43 unsigned deref() { return --m_refCount; }
44 bool hasOneRef() { return m_refCount == 1; }
dglazkov 2013/10/21 18:24:10 Whoa! Why did you reinvent RefPtr here? :)
tasak 2013/10/25 05:23:13 I see. I re-implemented RefPtr... I made StyleShee
45 StyleSheetContents* contents() { return m_contents.get(); }
46
47 private:
48 CachedStyleSheetContents(PassRefPtr<StyleSheetContents> contents) : m_refCou nt(0), m_contents(contents) { }
49
50 unsigned m_refCount;
51 RefPtr<StyleSheetContents> m_contents;
46 }; 52 };
47 53
48 class MatchedPropertiesCache { 54 class StyleSheetContentsCache {
49 WTF_MAKE_NONCOPYABLE(MatchedPropertiesCache); 55 WTF_MAKE_NONCOPYABLE(StyleSheetContentsCache);
50 public: 56 public:
51 MatchedPropertiesCache(); 57 StyleSheetContentsCache();
52 58
53 const CachedMatchedProperties* find(unsigned hash, const StyleResolverState& , const MatchResult&); 59 StyleSheetContents* find(const AtomicString& sheetText);
54 void add(const RenderStyle*, const RenderStyle* parentStyle, unsigned hash, const MatchResult&); 60 void add(const AtomicString& sheetText, StyleSheetContents*);
55 61 void remove(const AtomicString& sheetText);
56 void clear(); 62 void clear();
57 63
58 static bool isCacheable(const Element*, const RenderStyle*, const RenderStyl e* parentStyle);
59
60 private: 64 private:
61 // Every N additions to the matched declaration cache trigger a sweep where entries holding 65 void sweep(Timer<StyleSheetContentsCache>*);
62 // the last reference to a style declaration are garbage collected.
63 void sweep(Timer<MatchedPropertiesCache>*);
64 66
65 unsigned m_additionsSinceLastSweep; 67 unsigned m_additionsSinceLastSweep;
66 68
67 typedef HashMap<unsigned, OwnPtr<CachedMatchedProperties> > Cache; 69 typedef HashMap<AtomicString, OwnPtr<CachedStyleSheetContents> > Cache;
68 Cache m_cache; 70 Cache m_cache;
69 71
70 Timer<MatchedPropertiesCache> m_sweepTimer; 72 Timer<StyleSheetContentsCache> m_sweepTimer;
71 }; 73 };
72 74
73 } 75 }
74 76
75 #endif 77 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698