Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2855283002: Reland: [infra] Roll clang to match the version used by Flutter (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland: [infra] Roll clang to match the version used by Flutter Flutter uses the same clang toolchain as Fuchsia. This CL puts Dart on that toolchain, as well. This roll should entail no changes to glibc version requirements on Linux. The Fuchsia buildtools distribute clang-format with the toolchain rather than separately, so this CL introduces forwarding scripts that are copied to the right place under //buildtools. This CL sets the default for the number of workers in //tools/gn.py to 1, as the newer GN version fails occasionally when run concurrently with other invocations. As Flutter does, this CL uses the clang toolchain to build for Android. Thus, it is now possible to build for Android on MacOS. This change is a prerequisite for assembling the SDK in GN rather than with a python script: https://codereview.chromium.org/2848943003/ and will be nicer for making prebuilt SDKs for Fuchsia. Committed: https://github.com/dart-lang/sdk/commit/6bf2c800fda97d21c439ee8e6d3decc8d2b727c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -1801 lines) Patch
M DEPS View 7 chunks +16 lines, -121 lines 0 comments Download
M build/config/android/config.gni View 2 chunks +6 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 5 chunks +22 lines, -34 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +10 lines, -1 line 0 comments Download
M build/toolchain/linux/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A tools/android/VERSION_LINUX_NDK View 1 chunk +1 line, -0 lines 0 comments Download
A tools/android/VERSION_LINUX_SDK View 1 chunk +1 line, -0 lines 0 comments Download
A tools/android/VERSION_MACOSX_NDK View 1 chunk +1 line, -0 lines 0 comments Download
A tools/android/VERSION_MACOSX_SDK View 1 chunk +1 line, -0 lines 0 comments Download
A tools/android/download_android_tools.py View 1 chunk +104 lines, -0 lines 0 comments Download
M tools/build.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/buildtools/linux64/clang-format View 1 chunk +20 lines, -0 lines 0 comments Download
A tools/buildtools/mac/clang-format View 1 chunk +20 lines, -0 lines 0 comments Download
A tools/buildtools/update.py View 1 chunk +88 lines, -0 lines 0 comments Download
A tools/buildtools/win/clang-format.exe.sha1 View 1 chunk +2 lines, -0 lines 0 comments Download
D tools/clang/scripts/update.py View 1 chunk +0 lines, -909 lines 0 comments Download
D tools/clang/scripts/update.sh View 1 chunk +0 lines, -724 lines 0 comments Download
M tools/gn.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/ninja.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
zra
TBR
3 years, 7 months ago (2017-05-03 22:42:22 UTC) #2
zra
3 years, 7 months ago (2017-05-03 22:42:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bf2c800fda97d21c439ee8e6d3decc8d2b727c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698