third_party/WebKit/LayoutTests/fast/dom/Window/window-open-invalid-url.html - Issue 2855263004: Throw in window.open() when an invalid URL is being passed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/Window/window-open-invalid-url.html

Issue 2855263004: Throw in window.open() when an invalid URL is being passed (Closed)

Patch Set: updates Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>window.open: invalid URL</title>

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5 <script>

	6 test(() => {

	7 assert_throws("SyntaxError", () => { self.open("http:"); });
	foolip 2017/05/05 11:21:29 This is the same as https://github.com/w3c/web-pla This is the same as https://github.com/w3c/web-platform-tests/pull/5776, is it OK to wait for that to be imported to avoid duplicate tests? jochen (gone - plz use gerrit) 2017/05/05 11:25:51 I don't know why the wpt/url isn't yet included, a Show quoted text On 2017/05/05 at 11:21:29, foolip wrote: > This is the same as https://github.com/w3c/web-platform-tests/pull/5776, is it OK to wait for that to be imported to avoid duplicate tests? I don't know why the wpt/url isn't yet included, and from the imports I've seen so far, this might or might not be trivial to do :/ So I'd rather go with the duplicate test for now foolip 2017/05/05 11:28:55 Oh, importing that is https://codereview.chromium. Show quoted text On 2017/05/05 11:25:51, jochen wrote: > On 2017/05/05 at 11:21:29, foolip wrote: > > This is the same as https://github.com/w3c/web-platform-tests/pull/5776, is it > OK to wait for that to be imported to avoid duplicate tests? > > I don't know why the wpt/url isn't yet included, and from the imports I've seen > so far, this might or might not be trivial to do :/ > > So I'd rather go with the duplicate test for now Oh, importing that is https://codereview.chromium.org/2855023002/, reviewer is OOO though. Duplicate test it is.
	8 }, "Check that window.open() throws on an invalid URL.");

	9 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | third_party/WebKit/Source/core/frame/Window.idl » ('J')